-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use WIX_NATIVE_MACHINE to detect native architecture of target machine #8000
Conversation
d5ef365
to
d4c46b2
Compare
<?if $(var.Platform)~=x86?> | ||
<?define InstallerArchitecture="X86"?> | ||
<?define InstallerNativeMachine=332?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably define these constants so that everyone can use them eventually. For now we do have the link, but something like <?define NativeMachine_ARM64=43620?>
in a shared include or lib would be nice for 7.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm doing that in installer where we need all the values in the bundle. Here we need the value for a single arch.
Yeah consolidating more would be nice.
Manually tested this in dotnet/runtime by building host. x64 install
This will require that dotnet/runtime#59500 be merged before runtime can ingest this change. |
/backport to release/6.0 |
dotnet#8000) * Use WIX_NATIVE_MACHINE to detect native architecture of target machine * Reference WIX_NATIVE_MACHINE property
Here's this working on an ARM64 machine. 👍
|
This leverages the feature I added to Wix which reads the native architecture from the recent feature:
wixtoolset/wix3@75699d8