Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workloads] Use the dual signed wix version for workload msis #59500

Merged
merged 2 commits into from
Oct 6, 2021

Conversation

lewing
Copy link
Member

@lewing lewing commented Sep 22, 2021

Fixes half of #59498

@lewing lewing requested a review from directhex September 22, 2021 20:25
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Sep 22, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes half of #59498

Author: lewing
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@lewing lewing changed the title Use the dual signed wix version for workload msis [workloads] Use the dual signed wix version for workload msis Sep 22, 2021
@lewing
Copy link
Member Author

lewing commented Sep 22, 2021

/backport to release/6.0-rc2

@github-actions
Copy link
Contributor

Started backporting to release/6.0-rc2: https://github.com/dotnet/runtime/actions/runs/1263380417

@lewing
Copy link
Member Author

lewing commented Sep 23, 2021

runtime (Libraries Test Run checked coreclr Linux_musl arm64 Release)
https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-59500-merge-a1559d53be114c048e/System.Text.RegularExpressions.Tests/1/console.f989b822.log?sv=2019-07-07&se=2021-10-13T15%3A29%3A34Z&sr=c&sp=rl&sig=NhwXNpBox%2FCbd66qPzy%2FLXrtg%2BxxH6RSLzt6wPWde8E%3D

  Starting:    System.Text.RegularExpressions.Tests (parallel test collections = on, max threads = 4)
    System.Text.RegularExpressions.Tests.RegexMatchTests.Match_ExcessPrefix(engine: SourceGenerated) [FAIL]
      Half-way through waiting for remote process.
      Timed out at 9/23/2021 3:35:31 PM after 60000ms waiting for remote process.
      	Process ID: 263
      	Handle: 1880
      	Name: dotnet
      	MainModule: /root/helix/work/correlation/dotnet
      	StartTime: 9/23/2021 3:34:31 PM
      	TotalProcessorTime: 00:01:03.0900000
      
      Stack Trace:
        /_/src/Microsoft.DotNet.RemoteExecutor/src/RemoteInvokeHandle.cs(224,0): at Microsoft.DotNet.RemoteExecutor.RemoteInvokeHandle.Dispose(Boolean disposing)
        /_/src/Microsoft.DotNet.RemoteExecutor/src/RemoteInvokeHandle.cs(57,0): at Microsoft.DotNet.RemoteExecutor.RemoteInvokeHandle.Dispose()
        /_/src/libraries/System.Text.RegularExpressions/tests/Regex.Match.Tests.cs(1095,0): 

@lewing
Copy link
Member Author

lewing commented Sep 23, 2021

@stephentoub several lanes here are failing due to the regex source generator tests. #59541

@ericstj
Copy link
Member

ericstj commented Oct 6, 2021

@lewing did you want to add #60008 to this PR as well?

@lewing
Copy link
Member Author

lewing commented Oct 6, 2021

@lewing did you want to add #60008 to this PR as well?

done

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericstj
Copy link
Member

ericstj commented Oct 6, 2021

Tested this manually by pulling over changes from dotnet/arcade#8000 and confirmed it works as expected.

@lewing lewing merged commit 74ba133 into dotnet:main Oct 6, 2021
@lewing lewing deleted the wix-dual-signed branch October 6, 2021 22:23
@ghost ghost locked as resolved and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants