Skip to content

Commit

Permalink
Remove setting IsStableBuild in Directory.Build.props
Browse files Browse the repository at this point in the history
It is a no-op.

Arcade already sets this in https://github.com/dotnet/arcade/blob/7fff497cdf80039a4f2996699e5561e50812d948/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L55-L57 and as we discovered in #59309 the DotNetFinalVersionKind property isn't even set at that point.
  • Loading branch information
akoeplinger authored Dec 4, 2024
1 parent 3fe0618 commit 350ea9f
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,6 @@
'$(IsBenchmarkProject)' == 'true' OR
'$(IsPublishedAppTestProject)' == 'true' OR
$(IsUnitTestProject) ">false</IsShipping>

<!--
Following logic mimics core-setup approach as well as
https://github.com/dotnet/arcade/blob/694d59f090b743f894779d04a7ffe11cbaf352e7/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L30-L31
$(DotNetFinalVersionKind) is set globally when doing final aka stable builds. Arcade infrastructure should pick
up $(IsStableBuild) automatically; property is also used to control prerelease branding.
-->
<IsStableBuild>false</IsStableBuild>
<IsStableBuild Condition=" '$(DotNetFinalVersionKind)' == 'release' ">true</IsStableBuild>
</PropertyGroup>

<!-- Disable logging of some task parameters or metadata to reduce binlog size.
Expand Down

0 comments on commit 350ea9f

Please sign in to comment.