Import Common.props after the Arcade.SDK in props file #59309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Common.props file now depends on the `DotNetBuild` property which isn't available before the Arcade SDK is imported. Therefore move the import down after the Arcade SDK is imported. I verified (for every single property defined in Common.props) that it isn't used anywhere in the Arcade.SDK or in aspnetcore before where it's now imported.
dotnet-issue-labeler
bot
added
the
area-infrastructure
|
Another (unrelated) case that is broken today is aspnetcore/Directory.Build.props Line 59 in 3fe0618
|
akoeplinger
added a commit
that referenced
this pull request
Dec 4, 2024
It is a no-op. Arcade already sets this in https://github.com/dotnet/arcade/blob/7fff497cdf80039a4f2996699e5561e50812d948/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L55-L57 and as we discovered in #59309 the DotNetFinalVersionKind property isn't even set at that point.
akoeplinger
approved these changes
Dec 4, 2024
akoeplinger
added a commit
that referenced
this pull request
Dec 4, 2024
It is a no-op. Arcade already sets this in https://github.com/dotnet/arcade/blob/7fff497cdf80039a4f2996699e5561e50812d948/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L55-L57 and as we discovered in #59309 the DotNetFinalVersionKind property isn't even set at that point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Common.props file now depends on the
DotNetBuildproperty which isn't available before the Arcade SDK is imported. Therefore move the import down after the Arcade SDK is imported. I verified (for every single property defined in Common.props) that it isn't used anywhere in the Arcade.SDK or in aspnetcore before where it's now imported.It felt more correct to move this down than to change the condition in Common.props from
DotNetBuildtoDotNetBuildRepo. I don't see any reason why to restrict that file from using Arcade SDK properties. The general recommendation from the Arcade team is to import the Arcade SDK as early as possbile in the Directory.Build.* files.