Skip to content

Commit

Permalink
Import Common.props after the Arcade.SDK in props file (#59309)
Browse files Browse the repository at this point in the history
The Common.props file now depends on the `DotNetBuild` property which isn't available before the Arcade SDK is imported.
Therefore move the import down after the Arcade SDK is imported.
I verified (for every single property defined in Common.props) that it isn't used anywhere in the Arcade.SDK or in aspnetcore before where it's now imported.
  • Loading branch information
ViktorHofer authored Dec 4, 2024
1 parent 9eb2534 commit de76fa2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<Project>
<Import Project="eng\Common.props" />

<PropertyGroup>
<AccelerateBuildsInVisualStudio>true</AccelerateBuildsInVisualStudio>
Expand Down Expand Up @@ -98,6 +97,7 @@
<Import Project="eng\QuarantinedTests.BeforeArcade.props" />
<Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />
<Import Project="eng\QuarantinedTests.AfterArcade.props" />
<Import Project="eng\Common.props" />

<PropertyGroup>
<Product>Microsoft ASP.NET Core</Product>
Expand Down

0 comments on commit de76fa2

Please sign in to comment.