Skip to content

Commit

Permalink
Do a few tricks to shorten the intermediate output paths for the runt…
Browse files Browse the repository at this point in the history
…ime packs (#59479)

* Do a few tricks to shorten the intermediate output paths for the runtime packs

The Wix tooling can't handle long paths, which is blocking VMR integration. This change gets our paths to be short enough that even a long-named analyzer's resource DLL won't go past MAX_PATH in a VMR build.

* Set OutDirName for the ref pack as well.

* Adjust path to RuntimeList
  • Loading branch information
jkoritzinsky authored Dec 14, 2024
1 parent 1882c89 commit eaf6162
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 1 deletion.
7 changes: 7 additions & 0 deletions src/Framework/App.Ref/src/Directory.Build.props
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<Project>
<PropertyGroup>
<OutDirName Condition="'$(MSBuildProjectName)' == 'Microsoft.AspNetCore.App.Ref'">aspnetcore-ref</OutDirName>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
</PropertyGroup>
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory)..\, Directory.Build.props))\Directory.Build.props" />
</Project>
7 changes: 7 additions & 0 deletions src/Framework/App.Runtime/src/Directory.Build.props
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<Project>
<PropertyGroup>
<OutDirName Condition="'$(MSBuildProjectName)' == 'Microsoft.AspNetCore.App.Runtime'">aspnetcore-sfx</OutDirName>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
</PropertyGroup>
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory)..\, Directory.Build.props))\Directory.Build.props" />
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
This depends on internal implementation details of the SharedFramework SDK and should be changed to use a supported mechanism
to discover the runtime list.
-->
<None Include="$(ArtifactsObjDir)Microsoft.AspNetCore.App.Runtime\$(Configuration)\$(DefaultNetCoreTargetFramework)\$(TargetRuntimeIdentifier)\RuntimeList.xml"
<None Include="$(ArtifactsObjDir)aspnetcore-sfx\$(Configuration)\$(TargetRuntimeIdentifier)\RuntimeList.xml"
CopyToOutputDirectory="PreserveNewest" />

<!-- Ignore aspnetcorev2_inprocess because tests expect only managed assemblies in this item group. -->
Expand Down

0 comments on commit eaf6162

Please sign in to comment.