Do a few tricks to shorten the intermediate output paths for the runtime packs #59479
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime packs The Wix tooling can't handle long paths, which is blocking VMR integration. This change gets our paths to be short enough that even a long-named analyzer's resource DLL won't go past MAX_PATH in a VMR build.
dotnet-issue-labeler
bot
added
the
area-infrastructure
|
It's depressing that we are dealing with max path issues at the end of 2024. 😢 |
eerhardt
reviewed
Dec 13, 2024
eerhardt
reviewed
Dec 13, 2024
ViktorHofer
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Wix tooling can't handle long paths, which is blocking VMR integration. This change gets our paths to be short enough that even a long-named analyzer's resource DLL won't go past MAX_PATH in a VMR build.
Will unblock dotnet/sdk#45430