-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omnisharp + Razor Source generator = sad face #30750
Comments
FYI @captainsafia |
Follow-up: it looks like this only repros on Windows and pertains specifically to the casing used in the drive letter. The same issue doesn't repro on macOS. |
Thanks for contacting us. |
Marking this as external. Part of this is also being tracked in dotnet/roslyn#51768 in addition to the issue referenced above. |
Workaround for dotnet/aspnetcore#30750
Workaround for dotnet/aspnetcore#30750
Workaround for dotnet/aspnetcore#30750
Workaround for dotnet/aspnetcore#30750
Workaround for dotnet/aspnetcore#30750
Workaround for dotnet/aspnetcore#30750
Closing this as we don't have control over this. We're following up with the OmniSharp team internally to get to some resolution on this from them. |
As part of addressing dotnet/aspnetcore#30750, we had added a workaround to the RazorSDK to ensure building inside O# worked. This issue is being resolved as part of the upcoming O# v1.37.16. In the meanwhile, the workaround affects sourcelink for razor files. Fixes dotnet/aspnetcore#37182
As part of addressing dotnet/aspnetcore#30750, we had added a workaround to the RazorSDK to ensure building inside O# worked. This issue is being resolved as part of the upcoming O# v1.37.16. In the meanwhile, the workaround affects sourcelink for razor files. Fixes dotnet/aspnetcore#37182
Workaround for dotnet/aspnetcore#30750
Noticed this as part of my dotnet-watch work. This was reproduced on a Windows machine, I'm not sure what the behavior is like on xplat. With With O# sharp enabled, the generated editorconfig has lower cased paths. For e.g.
If I disable it and rebuild, the editorconfig uses the casing from the path as-is:
Notice the difference in casing -
D:/
vsd:/
In dotnet-watch, I'm hosting Roslyn in-proc. I use an MSBuildWorkspace, which uses the path with the same casing as $PWD i.e. in my case
D:\
. When the in-proc compiler runs Razor source generator, it fails unable to find the metadata that it expects to be present because AnalyzerOptions lookups are case sensitive.In fact, if I open up the generated editor config file in VSCode and build, I can see it flash (I guess first when msbuild updates it and then immediately when O# does it's thing). Occasionally building the app will fail since there's a race between MSBuild generating an editorconfig and O#.
The text was updated successfully, but these errors were encountered: