Workaround O# path bug #16434
Merged
Workaround O# path bug #16434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
pranavkm
force-pushed
the
prkrishn/workaround-omnisharp
branch
from
06dbc91
to
1d373dc
Compare
captainsafia
approved these changes
Mar 19, 2021
pranavkm
force-pushed
the
prkrishn/workaround-omnisharp
branch
from
1d373dc
to
46db82c
Compare
Workaround for dotnet/aspnetcore#30750
pranavkm
force-pushed
the
prkrishn/workaround-omnisharp
branch
from
46db82c
to
4f862db
Compare
| @@ -74,15 +74,18 @@ public void Build_ErrorInGeneratedCode_ReportsMSBuildError() | |||
| var projectDirectory = CreateAspNetSdkTestAsset(testAsset); | |||
|
|
|||
| var filePath = Path.Combine(projectDirectory.Path, "Views", "Home", "Index.cshtml"); | |||
There was a problem hiding this comment.
I wonder if we should just make this a relative path and check for the existence of that instead of having the conditional check.
There was a problem hiding this comment.
I was hoping we would undo this PR after we get o# to fix their bug. But using a relative path seems like a good long term fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for dotnet/aspnetcore#30750