-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AuthenticationService.ts used in Microsoft.Authentication.WebAssembly.Msal missing popup-Api #54756
Comments
I would be happy to implement those changes. Before I begin though i would like to know if you guys have anything special to consider. For now I'd try to replicate the login behaviour to logout. In C# there is a MsalProviderOption Property called "LoginMode" should a "LogoutMode" exist as well or should the value of LoginMode be used? If so I feel like the naming is odd. |
Added Singout API Issue: dotnet#54756
I have done my best to match the code. I've used the v8.0.3 tag as base, because that's my target. |
The change ihkN@39b9c42 seems to work but there is a catch. The WASM App is not being notified by the popup about a successful logout. I am not sure right now how the callback is being handled. After a user picks a an account to singout, the popup closes as expected but the wasm app itself just stays at The issues #53131 #34990 and #49956 seem to be kind of related. At least the symptom is similiar, which is "stuck at 'processing logout...'. Also i've read that wasm specifically does not support "Front-Channel-Logout" right now. Is this information still valid? I think @javiercn did mention this in an Issue i am sadly unable to find at the moment. Right now my only solution to atleast apparently logout is the following:
I know that it is advised to use "NavigationManager.NavigateToLogout(...)", but it won't redirect at all. And it is lacking the ForceReload Property, effectively not singing out. I feel like this is a bigger problem than just missing the popup api in AuthenticationService.ts. |
I also have this issue. |
@mkArtakMSFT can you give me any information about the state of this issue? This is a security issue and shouldn't be treated as a enhancement! |
The AuthenticationService.ts used in
namespace Microsoft.Authentication.WebAssembly.Msal
does not try to use the popup api on signout.I would assume that the
redirect_in_iframe
error would be resolved by adding the popup mechanism.This is AuthenticationService.ts i looked at.
The general problem is that i am able to sign in with my Blazor Wasm application which does fallback to the popup api (in an iframe) for signing in. But for signout it doesn't.
The
AuthenticationService.ts
doesn't include any signout specific popup calls. For log in it does fallback though.Adding the fallback mechanism therefore should resolve
redirect_in_iframe
thrown in an iframe while signing out.Originally posted by @tts-jwiebe in #54665 (comment)
The text was updated successfully, but these errors were encountered: