Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/3.1] Target 3.1.0 shared framework in global tools #27598

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Nov 7, 2020

  • Required dependencies are not listed #19108
  • ensure the packaged runtimeconfig.json file uses the 3.1.0 shared framework
    • disable $(TargetLatestDotNetRuntime) in tool projects
    • skip @(FrameworkReference) item update if $(TargetLatestDotNetRuntime) is disabled

nit: Move $(PackAsTool) settings together


Description

In 3.1.x servicing, the global tools shipped from the dotnet/aspnetcore repo had an undeclared dependency on the latest shared framework. Installing, say, the 3.1.9 version of dotnet-sql-cache went fine. But, attempts to run it fail with the output below unless the 3.1.9 shared framework was available.

> dotnet-sql-cache
It was not possible to find any compatible framework version
The framework 'Microsoft.NETCore.App', version '3.1.9' was not found.
  - The following frameworks were found:
      2.1.21 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
      3.1.7 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
      5.0.0-rc.2.20475.5 at [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]

You can resolve the problem by installing the specified framework and/or SDK.

The specified framework can be found at:
  - https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=3.1.9&arch=x64&rid=win10-x64

Customer Impact

From 3.1.11 forward, customers will be able to install the latest global tools from dotnet/aspnetcore without also updating their installed shared frameworks.

Regression?

Yes but from way back in 2.1.x. Those tools worked fine because, though the runtimeconfig.json files we shipped referenced the latest version of Microsoft.NETCore.App, that package could be resolved when the tool was installed.

Risk (see taxonomy)

Incredibly small. The only possible risk would be a tool we ship from dotnet/aspnetcore depending on a fix in a serviced shared framework assembly. Such a dependency could be considered a breaking change and should be avoided.

Original issue and/or the PR to master.

Packaging impact? (if a libraries change)

None

- #19108
- ensure the packaged runtimeconfig.json file uses the 3.1.0 shared framework
  - disable `$(TargetLatestDotNetRuntime)` in tool projects
  - skip `@(FrameworkReference)` item update if `$(TargetLatestDotNetRuntime)` is disabled

nit: Move `$(PackAsTool)` settings together
@dougbu dougbu requested a review from a team November 7, 2020 00:18
@dougbu
Copy link
Member Author

dougbu commented Nov 7, 2020

Will add ask mode template shortly&hellip:

@dougbu dougbu added this to the 3.1.11 milestone Nov 7, 2020
@dougbu dougbu added ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. * NO MERGE * Do not merge this PR as long as this label is present. feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform blocked The work on this issue is blocked due to some dependency labels Nov 7, 2020
@dougbu
Copy link
Member Author

dougbu commented Nov 7, 2020

Blocked until branch is open

@dougbu dougbu added the Servicing-approved Shiproom has approved the issue label Nov 7, 2020
@wtgodbe wtgodbe merged commit a8a9e00 into release/3.1 Nov 10, 2020
@wtgodbe wtgodbe deleted the dougbu/3.1/tool.runtime.config.19108 branch November 10, 2020 22:51
@dougbu dougbu removed the blocked The work on this issue is blocked due to some dependency label Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ask-mode This issue / PR is a patch candidate which we will bar-check internally before patching it. feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform * NO MERGE * Do not merge this PR as long as this label is present. Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants