Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Target 6.0.0 shared framework in global tools in servicing #27600

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Nov 7, 2020

  • Required dependencies are not listed #19108
  • ensure the packaged runtimeconfig.json file uses the 6.0.0 shared framework
    • disable $(TargetLatestDotNetRuntime) in tool projects
    • skip @(FrameworkReference) item update if $(TargetLatestDotNetRuntime) is disabled
  • essentially a no-op until after the 6.0.0 release

nit: Move $(PackAsTool) settings together

- #19108
- ensure the packaged runtimeconfig.json file uses the 6.0.0 shared framework
  - disable `$(TargetLatestDotNetRuntime)` in tool projects
  - skip `@(FrameworkReference)` item update if `$(TargetLatestDotNetRuntime)` is disabled
- essentially a no-op until after the 6.0.0 release

nit: Move `$(PackAsTool)` settings together
@dougbu dougbu requested a review from a team November 7, 2020 00:19
@dougbu dougbu added the feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform label Nov 7, 2020
@dougbu dougbu added this to the 6.0-preview1 milestone Nov 7, 2020
@dougbu dougbu merged commit c1ed3f3 into master Nov 9, 2020
@dougbu dougbu deleted the dougbu/master/tool.runtime.config.19108 branch November 9, 2020 19:27
captainsafia pushed a commit that referenced this pull request Nov 11, 2020
…27600)

- #19108
- ensure the packaged runtimeconfig.json file uses the 6.0.0 shared framework
  - disable `$(TargetLatestDotNetRuntime)` in tool projects
  - skip `@(FrameworkReference)` item update if `$(TargetLatestDotNetRuntime)` is disabled
- essentially a no-op until after the 6.0.0 release

nit: Move `$(PackAsTool)` settings together
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants