Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a few tricks to shorten the intermediate output paths for the runtime packs #59479

Merged
merged 3 commits into from
Dec 14, 2024
Merged

Do a few tricks to shorten the intermediate output paths for the runtime packs #59479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ce47bc
Do a few tricks to shorten the intermediate output paths for the runt…
jkoritzinsky Dec 13, 2024
3d68310
Set OutDirName for the ref pack as well.
jkoritzinsky Dec 13, 2024
3825910
Adjust path to RuntimeList
jkoritzinsky Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Framework/App.Ref/src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<Project>
<PropertyGroup>
<OutDirName Condition="'$(MSBuildProjectName)' == 'Microsoft.AspNetCore.App.Ref'">aspnetcore-ref</OutDirName>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
</PropertyGroup>
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory)..\, Directory.Build.props))\Directory.Build.props" />
</Project>
7 changes: 7 additions & 0 deletions src/Framework/App.Runtime/src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<Project>
<PropertyGroup>
<OutDirName Condition="'$(MSBuildProjectName)' == 'Microsoft.AspNetCore.App.Runtime'">aspnetcore-sfx</OutDirName>
jkoritzinsky marked this conversation as resolved.
Show resolved Hide resolved
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
eerhardt marked this conversation as resolved.
Show resolved Hide resolved
</PropertyGroup>
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory)..\, Directory.Build.props))\Directory.Build.props" />
</Project>
2 changes: 1 addition & 1 deletion src/Framework/test/Microsoft.AspNetCore.App.UnitTests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
This depends on internal implementation details of the SharedFramework SDK and should be changed to use a supported mechanism
to discover the runtime list.
-->
<None Include="$(ArtifactsObjDir)Microsoft.AspNetCore.App.Runtime\$(Configuration)\$(DefaultNetCoreTargetFramework)\$(TargetRuntimeIdentifier)\RuntimeList.xml"
<None Include="$(ArtifactsObjDir)aspnetcore-sfx\$(Configuration)\$(TargetRuntimeIdentifier)\RuntimeList.xml"
CopyToOutputDirectory="PreserveNewest" />

<!-- Ignore aspnetcorev2_inprocess because tests expect only managed assemblies in this item group. -->
Expand Down
Loading