-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Consolidate AssemblyTests, AssemblyNameTests, MethodInfoTests fixtures within System.Reflection location #33101
Conversation
…s within System.Reflection location
@dotnet-bot test Linux x64 Release Build |
@dotnet-bot test Packaging All Configurations x64 Debug Build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
cc: @steveharter |
# Conflicts: # src/System.Runtime/tests/System.Runtime.Tests.csproj
@stephentoub good to merge? |
From my perspective, yes, but I thought Steve Harter might want to review, too. |
@steveharter Could you please take a look? |
@danmosemsft can we get this merged soon? |
@MaximLipnin is there any reason you needed to duplicate the ForwardedTypesAssembly and UnloadableAssembly projects? It is causing race conditions in our build see https://github.com/dotnet/corefx/issues/33219. I'm going to remove these and just reference the ones under System.Reflection. |
As part of dotnet#33101 these assemblies were moved under System.Reflection but weren't deleted from System.Runtime so this work finishes up the move.
As part of dotnet#33101 these assemblies were moved under System.Reflection but weren't deleted from System.Runtime so this work finishes up the move.
Sorry for inconvenience, seems I forgot to delete those test assemblies from System.Runtime. |
…s within System.Reflection location (dotnet#33101)
* Remove duplcated test assemblies from System.Runtime As part of #33101 these assemblies were moved under System.Reflection but weren't deleted from System.Runtime so this work finishes up the move. * Disable Constructor_String_LoadVersionTest test Filed https://github.com/dotnet/corefx/issues/33249 to track it.
…s within System.Reflection location (dotnet/corefx#33101) Commit migrated from dotnet/corefx@c294ec4
…3224) * Remove duplcated test assemblies from System.Runtime As part of dotnet/corefx#33101 these assemblies were moved under System.Reflection but weren't deleted from System.Runtime so this work finishes up the move. * Disable Constructor_String_LoadVersionTest test Filed https://github.com/dotnet/corefx/issues/33249 to track it. Commit migrated from dotnet/corefx@388455c
It's a continuation of work done in #32738
The following fixtures were merged/moved to System.Reflection location:
/cc @marek-safar
Test methods mapping