Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Remove duplcated test assemblies from System.Runtime #33224

Merged
merged 2 commits into from
Nov 5, 2018

Conversation

weshaggard
Copy link
Member

As part of #33101 these
assemblies were moved under System.Reflection but weren't
deleted from System.Runtime so this work finishes up the move.

fixes https://github.com/dotnet/corefx/issues/33219

PTAL @Stoub @MaximLipnin

As part of dotnet#33101 these
assemblies were moved under System.Reflection but weren't
deleted from System.Runtime so this work finishes up the move.
@ViktorHofer
Copy link
Member

I think you meant @stephentoub and not @Stoub :D

Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Wes.

@weshaggard
Copy link
Member Author

test Linux x64 Release Build

@danmoseley
Copy link
Member

Test failure

Assert.Throws() Failure
Expected: typeof(System.IO.FileNotFoundException)
Actual:   (No exception was thrown)
Stack Trace :
   at System.Reflection.Tests.AssemblyNameTests.Constructor_String_LoadVersionTest() in /mnt/j/workspace/dotnet_corefx/master/linux-TGroup_netcoreapp+CGroup_Release+AGroup_x64+TestOuter_false_prtest/src/System.Reflection/tests/AssemblyNameTests.cs:line 55

@weshaggard
Copy link
Member Author

@dotnet-bot test this please

@weshaggard
Copy link
Member Author

@stephentoub @danmosemsft it does look like AssemblyNameTests.Constructor_String_LoadVersionTest seems to failing from multiple PR's. Are you guys seeing the same things? If it fails again I'm going to disable it as part of this PR.

@stephentoub
Copy link
Member

Are you guys seeing the same things?

Yes, though I was hoping it would be resolved by yours :)

@weshaggard
Copy link
Member Author

I'll resolve it by disabling the test and filing an issue.

@weshaggard
Copy link
Member Author

@joperezr @ericstj we probably should have another look at our packaging CI leg as it seems to be the long pole during our CI legs and taking more then an hour. We should see if we can streamline or perhaps prune some of the matrix.

@stephentoub stephentoub merged commit 388455c into dotnet:master Nov 5, 2018
@karelz karelz added this to the 3.0 milestone Nov 15, 2018
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
…3224)

* Remove duplcated test assemblies from System.Runtime

As part of dotnet/corefx#33101 these
assemblies were moved under System.Reflection but weren't
deleted from System.Runtime so this work finishes up the move.

* Disable Constructor_String_LoadVersionTest test

Filed https://github.com/dotnet/corefx/issues/33249 to track it.


Commit migrated from dotnet/corefx@388455c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition in usage of GenerateAssemblyInfo can cause test build breaks
5 participants