This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
Remove duplcated test assemblies from System.Runtime #33224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of dotnet#33101 these assemblies were moved under System.Reflection but weren't deleted from System.Runtime so this work finishes up the move.
I think you meant @stephentoub and not @Stoub :D |
stephentoub
approved these changes
Nov 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Wes.
ViktorHofer
approved these changes
Nov 2, 2018
test Linux x64 Release Build |
Test failure
|
@dotnet-bot test this please |
@stephentoub @danmosemsft it does look like AssemblyNameTests.Constructor_String_LoadVersionTest seems to failing from multiple PR's. Are you guys seeing the same things? If it fails again I'm going to disable it as part of this PR. |
Yes, though I was hoping it would be resolved by yours :) |
I'll resolve it by disabling the test and filing an issue. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…3224) * Remove duplcated test assemblies from System.Runtime As part of dotnet/corefx#33101 these assemblies were moved under System.Reflection but weren't deleted from System.Runtime so this work finishes up the move. * Disable Constructor_String_LoadVersionTest test Filed https://github.com/dotnet/corefx/issues/33249 to track it. Commit migrated from dotnet/corefx@388455c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #33101 these
assemblies were moved under System.Reflection but weren't
deleted from System.Runtime so this work finishes up the move.
fixes https://github.com/dotnet/corefx/issues/33219
PTAL @Stoub @MaximLipnin