Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples of relative path to apphost-embed-install-location.md #319

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Add examples of relative path to apphost-embed-install-location.md #319

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d01e84
Add examples of relative path to apphost-embed-install-location.md
elinor-fung Jul 31, 2024
b83737f
Update proposed/apphost-embed-install-location.md
elinor-fung Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions proposed/apphost-embed-install-location.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,13 @@ explicitly set to a value that does not include `AppRelative`, then setting
`AppHostRelativeDotNet` is meaningless - the SDK will not write the relative
path into the `apphost` and the `apphost` will not check for a relative path.

The path must not be rooted and will be considered relative to the app location
(the location of the `apphost` itself) at run time. For example, when running
`C:\dir\app.exe` or `/home/dir/app` with `AppHostRelativeDotNet` set to:
elinor-fung marked this conversation as resolved.
Show resolved Hide resolved
- `my_dotnet`: the app will look at `C:\dir\my_dotnet` or `/home/dir/my_dotnet`
- `./my_dotnet`: the app will look at `C:\dir\my_dotnet` or `/home/dir/my_dotnet`
- `../my_dotnet` the app will look at `C:\my_dotnet` or `/home/my_dotnet`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It would be good to know what the behavior would be if ../../ ends up going past drive root. Is there a check for that case or its undefined?

Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT Aug 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the meta point here is whatever the user defines as the relative path it is unmodified and we defer to the under lying OS file system APIs. I wouldn't do much more than provide an example of how we use it and state the precise semantics are at the mercy of the underlying file system.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the text indicate that the path is written into the apphost unmodified and we simply append it to the app location and call OS APIs to determine validity / existence.


## Updated behaviour

At a high level, the updated process and priority for `apphost` determining the
Expand Down
Loading