Add examples of relative path to apphost-embed-install-location.md #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronRobinsonMSFT
approved these changes
Jul 31, 2024
richlander
reviewed
Aug 1, 2024
| `C:\dir\app.exe` or `/home/dir/app` with `AppHostRelativeDotNet` set to: | ||
| - `my_dotnet`: the app will look at `C:\dir\my_dotnet` or `/home/dir/my_dotnet` | ||
| - `./my_dotnet`: the app will look at `C:\dir\my_dotnet` or `/home/dir/my_dotnet` | ||
| - `../my_dotnet` the app will look at `C:\my_dotnet` or `/home/my_dotnet` |
There was a problem hiding this comment.
Thanks! It would be good to know what the behavior would be if ../../ ends up going past drive root. Is there a check for that case or its undefined?
There was a problem hiding this comment.
I think the meta point here is whatever the user defines as the relative path it is unmodified and we defer to the under lying OS file system APIs. I wouldn't do much more than provide an example of how we use it and state the precise semantics are at the mercy of the underlying file system.
There was a problem hiding this comment.
I updated the text indicate that the path is written into the apphost unmodified and we simply append it to the app location and call OS APIs to determine validity / existence.
elinor-fung
commented
Aug 1, 2024
AaronRobinsonMSFT
approved these changes
Aug 1, 2024
richlander
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Examples of relative path and corresponding behaviour per: dotnet/sdk#42455 (comment)
cc @agocke @richlander @vitek-karas @dotnet/appmodel