[Symbol] Increase DebugInformationLevel for manifest entries #4732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hoyosjs don't we need this change for the symbol uploader work end to end? @mdh1418 it needs to be merged with the latest. I want to do a tools release soon so the new Microsoft.SymbolStore with the PDZ support is available to symbol.exe AND I need the tools release for the internal repo SOS for the native AOT SOS release. |
mdh1418
force-pushed
the
bump_debuginformationlevel
branch
from
2611173
to
e855b47
Compare
hoyosjs
reviewed
Sep 9, 2024
src/Microsoft.SymbolManifestGenerator/SymbolManifestGenerator.cs
Outdated
Show resolved
Hide resolved
hoyosjs
reviewed
Sep 9, 2024
src/Microsoft.SymbolManifestGenerator/SymbolManifestGenerator.cs
Outdated
Show resolved
Hide resolved
|
Also, can you please bump STJ to 8.0.4? I am not sure how we'll port the infra to 6.0 though. |
Originally the legacy field was added to account for a breaking change that was introduced in the symbol tool, where the field parsed was changed from Pascal to camel. As the updated symbol tool has been rolled out, we can remove the legacy field now.
hoyosjs
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping the DebugInformationLevel to be preferred over the default