Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Symbol] Increase DebugInformationLevel for manifest entries #4732

Merged
merged 3 commits into from
Sep 10, 2024
Merged

[Symbol] Increase DebugInformationLevel for manifest entries #4732

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e855b47
[Symbol] Increase DebugInformationLevel for manifest entries
mdh1418 Jun 11, 2024
cba7dce
Update DebugInformationLevel
mdh1418 Sep 9, 2024
75ba5b7
Remove legacy field
mdh1418 Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Microsoft.SymbolManifestGenerator/SymbolManifestGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ namespace Microsoft.SymbolManifestGenerator;

public static class SymbolManifestGenerator
{
private const int Private = 340;
private const int TargetDebugLevel = 0x154 | 0x1 | 0x500; // Private | Binary | SourceIndexed

public static bool GenerateManifest(ITracer tracer, DirectoryInfo dir, string manifestFileName, bool specialFilesRequireAdjacentRuntime = true)
{
Expand Down Expand Up @@ -63,8 +63,8 @@ public static bool GenerateManifest(ITracer tracer, DirectoryInfo dir, string ma
BasedirRelativePath = basedirRelativePath,
SymbolKey = runtimeCorrelatedKey.Index,
Sha512 = fileHash,
DebugInformationLevel = Private,
LegacyDebugInformationLevel = Private
DebugInformationLevel = TargetDebugLevel,
LegacyDebugInformationLevel = TargetDebugLevel
mdh1418 marked this conversation as resolved.
Show resolved Hide resolved
};

manifestData.Entries.Add(manifestDataEntry);
Expand Down