Upgrade mariner images to LLVM 16 #840
Conversation
There was a problem hiding this comment.
crossdeps-builder has extra contents (mostly sources and intermediate build outputs) that shouldn't be included in the final image, so we use it to build llvm, then only copy what we need out of it (llvm binaries, compiler-rt profile shared lib). crossdeps-llvm is a shared base image for the other cross-ARCH images, since it has the llvm cross-compiler. It is only one layer on top of crossdeps. crossdeps is used as the base image for both crossdeps-llvm and crossdeps-builder.
There was a problem hiding this comment.
crossdeps-builder has extra contents (mostly sources and intermediate build outputs) that shouldn't be included in the final image, so we use it to build llvm, then only copy what we need out of it (llvm binaries, compiler-rt profile shared lib). crossdeps-llvm is a shared base image for the other cross-ARCH images, since it has the llvm cross-compiler. It is only one layer on top of crossdeps. crossdeps is used as the base image for both crossdeps-llvm and crossdeps-builder.
|
Oops, I thought I had fixed that. Thanks. |
|
@agocke PTAL |
|
@mthalman please merge when you have a chance. |
This reverts commit ac313ee.
As per title, upgrades LLVM from 12.0.1 to 16.0.0. Because this version isn't available in the mariner repos, we build it from source on all platforms (whereas we used to get 12.0.1 from the repos for the amd64 image).
LLVM 16 is the first release that has started to use C++17 (previous releases were using C++14). At first this was causing the compiler-rt builds to fail, because not all C++17 features were available in the libstdc++ version that is installed in the rootfs (and no version supporting these features is available on xenial without using pinned packages from later releases). However, as long as we are careful to build only the compiler-rt library we need (profile), no C++ is required.
Contributes to dotnet/runtime#83428.