Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mariner images to latest with LLVM 16 #84676

Merged
merged 6 commits into from
May 10, 2023
Merged

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Apr 12, 2023

This pulls in the updates from dotnet/dotnet-buildtools-prereqs-docker#864 and moves to floating tags for the mariner images, which now build the product with LLVM 16.

Once this flows to dotnet-optimization, this will require updates to make the LLVM 16 tools available there. Before the opt data collected with new LLVM flows into runtime, I plan to fix #85785 so that local builds won't by default require clang-16.

@ghost ghost assigned sbomer Apr 12, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 12, 2023
@jeffhandley jeffhandley added area-Infrastructure-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Apr 20, 2023
@ghost
Copy link

ghost commented Apr 20, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Same as #84148, with extra changes to pull in dotnet/dotnet-buildtools-prereqs-docker#840.

Author: sbomer
Assignees: sbomer
Labels:

area-Infrastructure-coreclr

Milestone: -

@sbomer sbomer changed the title Build on mariner with llvm 16 Update mariner images to latest with LLVM 16 May 5, 2023
@sbomer sbomer marked this pull request as ready for review May 6, 2023 00:04
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@sbomer
Copy link
Member Author

sbomer commented May 9, 2023

I ran PlaintextPlatform aspnet benchmarks with these changes and didn't see a performance diff one way or another. Thanks @sebastienros! FYI @richlander

@sbomer
Copy link
Member Author

sbomer commented May 10, 2023

Build failures are #85949

@ghost ghost locked as resolved and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local linux builds should not enable PGO by default
4 participants