Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade mariner images to LLVM 16 #864

Merged
merged 3 commits into from
May 5, 2023
Merged

Upgrade mariner images to LLVM 16 #864

merged 3 commits into from
May 5, 2023

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented May 4, 2023

Now that all known issues with the LLVM12-based images are fixed we should be able to upgrade them again. @jkoritzinsky I compared the sanitizer static libs available on one of the machines (I picked arm64) and this is the diff:

> libclang_rt.asan_static-aarch64.a
> libclang_rt.hwasan-preinit-aarch64.a
< libclang_rt.scudo-aarch64.a
< libclang_rt.scudo_cxx-aarch64.a
< libclang_rt.scudo_cxx_minimal-aarch64.a
< libclang_rt.scudo_minimal-aarch64.a
> libclang_rt.scudo_standalone-aarch64.a
> libclang_rt.scudo_standalone_cxx-aarch64.a

janvorli
janvorli approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

src/cbl-mariner/2.0/cross/arm/Dockerfile Show resolved Hide resolved
jkoritzinsky
jkoritzinsky approved these changes May 4, 2023
View reviewed changes
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sanitizer file changes make sense. LGTM

@sbomer sbomer merged commit 53fee55 into dotnet:main May 5, 2023
@sbomer sbomer mentioned this pull request May 6, 2023
Merged
@akoeplinger akoeplinger mentioned this pull request Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvorli janvorli janvorli approved these changes

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@mthalman mthalman Awaiting requested review from mthalman

Assignees
No one assigned
Labels
area-dockerfiles untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbomer @jkoritzinsky @janvorli