-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sqlite: add transaction savepoint API #20228
Comments
System.Data.SQLite leveraged savepoints to implement nested transactions at the ADO.NET layer. I like the proposed design better. |
I think it was blocked on getting it into ADO.NET. I don't think it needs to be in 5.0. |
@ajcvickers this is simply waiting for the new methods to appear in a new version of the SDK (I think preview8). I know it's technically an enhancement, but I think we should just do it. It's trivial to do, there's virtually no risk (new APIs) and it would make sense to implement the new 5.0 API in 5.0... |
If it can go in this week, okay. Otherwise we'll discuss on Friday. |
@roji - Can you verify milestone/labels? |
Thanks for taking care of it @smitpatel |
Sqlite supports the SQL Standard for savepoints: https://www.sqlite.org/lang_savepoint.html. SqlClient and Npgsql expose APIs for this their DbTransaction implementation, and dotnet/runtime#33397 tracks adding the relevant APIs in System.Data.
The text was updated successfully, but these errors were encountered: