Implement savepoint API for Microsoft.Data.Sqlite #22869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricelam
approved these changes
Oct 2, 2020
| throw new InvalidOperationException(Resources.TransactionCompleted); | ||
| } | ||
|
|
||
| _connection.ExecuteNonQuery("SAVEPOINT " + savepointName); |
There was a problem hiding this comment.
Delimit and escape the identifier. Terminate statements.
SAVEPOINT "The ""SaveChanges"" Savepoint";There was a problem hiding this comment.
Done (though curious why terminate with semilcolon)
There was a problem hiding this comment.
IDK, statements just feel incomplete without a semicolon. 🤷♂️ But yeah, probably a waste of memory and CPU...
|
Sorry, should have just reused the old PR and addressed the comments. |
roji
force-pushed
the
SqliteSavepoints
branch
from
611b33b to
3903dff
Compare
|
Hello @roji! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
16 tasks
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20228
Rebases #22273 against main