Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/3.1] Add dependencies for CPD strict in efcore #3408

Merged
merged 1 commit into from
Aug 15, 2020
Merged

[release/3.1] Add dependencies for CPD strict in efcore #3408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions eng/Version.Details.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
<Uri>https://dev.azure.com/dnceng/internal/_git/dotnet-corefx</Uri>
<Sha>059a4a19e602494bfbed473dbbb18f2dbfbd0878</Sha>
</Dependency>
<Dependency Name="Microsoft.DotNet.PlatformAbstractions" Version="3.1.6">
<Uri>https://github.com/dotnet/core-setup</Uri>
<Sha>d7dd3dd2bad597a566915d6c8065fdffefef4be7</Sha>
</Dependency>
<Dependency Name="Microsoft.Win32.Registry" Version="4.7.0" Pinned="true">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While here, should we unpin the dependencies from corefx and use CoherentParentDependency="Microsoft.NETCore.App.Runtime.win-x64" for all of them❔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these specific packages, we want them to be pinned: dotnet/aspnetcore#18519.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That answers my question for Microsoft.Win32.Registry because we don't have the .0 auto-downgrades that dotnet/aspnetcore does. But, what about the following❔

  • System.IO.Pipelines
  • System.Runtime.CompilerServices.Unsafe
  • System.Security.Cryptography.Cng
  • Microsoft.NETCore.App.Ref
  • NETStandard.Library.Ref

The first two aren't pinned at .0 versions and System.IO.Pipelines is out-of-date (there's a 4.7.2 version). These are the ones (after deeper checks) I'm most wondering about unpinning now we have strict coherency to help us.

System.Security.Cryptography.Cng should be left where it is, again because we don't have the .0 auto-downgrades here.

I'm less sure about Microsoft.NETCore.App.Ref and NETStandard.Library.Ref because they aren't referenced in this repo or dotnet/aspnetcore. They're probably here to help strict coherency further up the stack. Either way, it's extremely unlikely those ref/ packs will need to be serviced. They're probably fine pinned.

Copy link
Member Author

@dougbu dougbu Aug 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's continue this discussion in dotnet/aspnetcore#24937

<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>0f7f38c4fd323b26da10cce95f857f77f0f09b48</Sha>
Expand Down
1 change: 1 addition & 0 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
-->
<PropertyGroup Label="Automated">
<!-- Packages from dotnet/core-setup -->
<MicrosoftDotNetPlatformAbstractionsPackageVersion>3.1.6</MicrosoftDotNetPlatformAbstractionsPackageVersion>
<MicrosoftNETCoreAppRefPackageVersion>3.1.0</MicrosoftNETCoreAppRefPackageVersion>
<MicrosoftNETCoreAppRuntimewinx64PackageVersion>3.1.8</MicrosoftNETCoreAppRuntimewinx64PackageVersion>
<MicrosoftNETCoreAppInternalPackageVersion>3.1.8-servicing.20414.2</MicrosoftNETCoreAppInternalPackageVersion>
Expand Down