Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SourceBuildUseMonoRuntime property, which is not SB specific #17778

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

directhex
Copy link
Contributor

@directhex directhex commented Sep 23, 2024

This is a coordinated cross-repo change, and might break the build until all four PRs are merged. The other three are:

dotnet/aspnetcore#58035
dotnet/sdk#43626
dotnet/runtime#108145

Ref: dotnet/source-build#4165

This is a coordinated cross-repo change, and might break the build until
all four PRs are merged. The other three are:

Ref: dotnet/source-build#4165
@directhex directhex requested a review from a team as a code owner September 23, 2024 14:19
Copy link
Contributor

✅ No release notes required

@MichaelSimons
Copy link
Member

might break the build until all four PRs are merged

I would expect this to break the mono build legs. Thoughts on pulling in the three repo changes as patches to prevent this? dependency flows have been very slow as of lately in main. I would like to avoid breaking source-build CI for anything beyond a couple of days.

@directhex
Copy link
Contributor Author

might break the build until all four PRs are merged

I would expect this to break the mono build legs. Thoughts on pulling in the three repo changes as patches to prevent this? dependency flows have been very slow as of lately in main. I would like to avoid breaking source-build CI for anything beyond a couple of days.

Patches in sdk.git? Not a bad idea. Let me refresh my memory on how to deploy those.

@MichaelSimons
Copy link
Member

Patches in sdk.git? Not a bad idea. Let me refresh my memory on how to deploy those.

Yes - A couple references to help:

SB patching guidelines
Samples from the past

@ViktorHofer ViktorHofer enabled auto-merge (squash) October 23, 2024 05:11
@ViktorHofer
Copy link
Member

@dotnet/fsharp-team-msft please approve

@ViktorHofer ViktorHofer merged commit e49b91f into dotnet:main Oct 23, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants