Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VMR] Rename SourceBuildUseMonoRuntime property, it's not SB-specific #4165

Closed
directhex opened this issue Feb 26, 2024 · 1 comment
Closed

[VMR] Rename SourceBuildUseMonoRuntime property, it's not SB-specific #4165

directhex opened this issue Feb 26, 2024 · 1 comment
Assignees
@ViktorHofer
Labels
area-unified-build

Comments

@directhex
Copy link

This property needs to be renamed in runtime, installer, and aspnetcore, to reflect its status as a general DotNetBuild property not a source-build-only one

See dotnet/installer#18777 discussion
directhex added a commit to directhex/sdk that referenced this issue Sep 23, 2024
@directhex
Rename SourceBuildUseMonoRuntime property, which is not SB specific
298a304 
This is a coordinated cross-repo change, and might break the build until
all four PRs are merged. The other three are:

Ref: dotnet/source-build#4165
directhex added a commit to directhex/runtime that referenced this issue Sep 23, 2024
@directhex
Rename SourceBuildUseMonoRuntime property, which is not SB specific
012ce35 
This is a coordinated cross-repo change, and might break the build until
all four PRs are merged. The other three are:

Ref: dotnet/source-build#4165
directhex added a commit to directhex/aspnetcore that referenced this issue Sep 23, 2024
@directhex
Rename SourceBuildUseMonoRuntime property, which is not SB specific
298f87a 
This is a coordinated cross-repo change, and might break the build until
all four PRs are merged. The other three are:

Ref: dotnet/source-build#4165
directhex added a commit to directhex/fsharp that referenced this issue Sep 23, 2024
@directhex
Rename SourceBuildUseMonoRuntime property, which is not SB specific
bd4e085 
This is a coordinated cross-repo change, and might break the build until
all four PRs are merged. The other three are:

Ref: dotnet/source-build#4165
This was referenced Sep 23, 2024
Merged
Merged
Merged
Merged
@ViktorHofer ViktorHofer self-assigned this Oct 22, 2024
@ViktorHofer
Copy link
Member

Fixed by dotnet/sdk#43626

ViktorHofer pushed a commit to dotnet/fsharp that referenced this issue Oct 23, 2024
@directhex
Rename SourceBuildUseMonoRuntime property, which is not SB specific (#…
e49b91f 
…17778)

This is a coordinated cross-repo change, and might break the build until
all four PRs are merged. The other three are:

Ref: dotnet/source-build#4165
ViktorHofer added a commit to dotnet/runtime that referenced this issue Oct 23, 2024
@directhex @ViktorHofer
Rename SourceBuildUseMonoRuntime property, which is not SB specific (#…
9ecef8c 
…108145)

This is a coordinated cross-repo change, and might break the build until
all four PRs are merged. The other three are:

Ref: dotnet/source-build#4165

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
ViktorHofer pushed a commit to dotnet/aspnetcore that referenced this issue Oct 23, 2024
@directhex
Rename SourceBuildUseMonoRuntime property, which is not SB specific (#…
d8acb6d 
…58035)

This is a coordinated cross-repo change, and might break the build until
all four PRs are merged. The other three are:

Ref: dotnet/source-build#4165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ViktorHofer ViktorHofer

Labels
area-unified-build
Projects
.NET Unified Build
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@directhex @ViktorHofer @MichaelSimons