Fix #282 - Remove duplicate 'Visual F# Items' node for project items #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was added a while back because we had the opposite problem: items were mysteriously appearing directly under the root. See http://visualfsharp.codeplex.com/workitem/118 At some point another fix must have restored the expected 'Visual F# Items' node. Thus we now need to revert the original fix. fixes dotnet#282
|
/cc @KevinRansom @dungpa @enricosada for review |
|
👍 |
|
seem ok, but i cant repro the bug, so cannot try the fix |
|
LGTM. |
|
Approved 5/29 by ML Shiproom. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shiproom template:
At some point another fix to our templates VSIX must have restored the original expected behavior here, thus turning the "fix" from earlier into a new bug where we have too many nodes in the "add new item" dialog.