-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further possible fix to reduce memory usage #6390
Conversation
@KevinRansom I prefer this one to #6389 @TIHan What do you think? @davidkean may also want to review |
Thanks |
FYI, I just had to revert this in #6468 due to a build failure in |
Pr to fix build issue for #648:
|
@auduchinok asked about this. The use of two caches is explained by these two comments:
|
I have evaluated this change and with the current internal project that I've been testing, this significantly reduced memory consumption after a find all refs. Before, we would reach 2.6gb in VS process, and now it hits 1.9gb specifically with this change. This is fantastic. I was wondering why 16.1 was not hitting the 2.6gb limit. |
@TIHan and others have noticed excessive creation of ILModuleReader. Here's a second possible fix, to be evaluated
The first possible fix is at #6389