Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Further possible fix to reduce memory usage" #6468

Merged
merged 1 commit into from
Apr 9, 2019
Merged

Revert "Further possible fix to reduce memory usage" #6468

merged 1 commit into from
Apr 9, 2019

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented Apr 9, 2019 •
edited
Loading

Reverts #6390 due to:

D:\Microsoft\visualfsharp2\src\absil\ilread.fs(4020,37): error FS0039: The value, namespace, type or module 'ilModuleReaderCache' is not defined. Maybe you want one of the following:�   ilModuleReaderCache1�   ilModuleReaderCache2�   ILModuleReaderCacheKey�   ilModuleReaderCache1Lock�   ILModuleReader [D:\Microsoft\visualfsharp2\src\fsharp\FSharp.Compiler.Private\FSharp.Compiler.Private.fsproj]

Failing master build showing the error.

@brettfo brettfo merged commit 7ad9e89 into master Apr 9, 2019
@brettfo brettfo mentioned this pull request Apr 9, 2019
Merged
KevinRansom added a commit that referenced this pull request Apr 9, 2019
@KevinRansom
Revert "Revert "Further possible fix to reduce memory usage (#6390)" (#…
def0484 
…6468)"

This reverts commit 7ad9e89.
KevinRansom pushed a commit that referenced this pull request Apr 9, 2019
@dsyme @KevinRansom
Revert "Revert "Further possible fix to reduce memory usage (#6390)" (#…
47c0425 
…6468)"

This reverts commit 7ad9e89.
@brettfo brettfo deleted the revert-6390-mem2 branch April 17, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brettfo