Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed type abbreviation from bypassing ByRefLike rules #7953

Merged
merged 6 commits into from
Dec 16, 2019

Conversation

TIHan
Copy link
Contributor

@TIHan TIHan commented Dec 11, 2019

This should be a simple fix. Resolves #6133 and #6133. Looks like this PR: #6135 was intended to do the same thing too.

@abelbraaksma
Copy link
Contributor

abelbraaksma commented Dec 11, 2019

Resolves #6133 and #6133.

@TIHan That's twice the same issue, did you mean to include another bug report as well? ;)

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think the test names should be different

src/fsharp/PostInferenceChecks.fs Outdated Show resolved Hide resolved
tests/fsharp/Compiler/Language/SpanTests.fs Outdated Show resolved Hide resolved
tests/fsharp/Compiler/Language/SpanTests.fs Outdated Show resolved Hide resolved
I like @cartermps test name changes.

Co-Authored-By: Phillip Carter <pcarter@fastmail.com>
@cartermp cartermp merged commit 230f82b into dotnet:master Dec 16, 2019
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* Trying to fix span type abbrev

* Fixed type abbrev issue on span

* Fixing build

* Update test

* Apply suggestions from code review

I like @cartermps test name changes.

Co-Authored-By: Phillip Carter <pcarter@fastmail.com>

* Update PostInferenceChecks.fs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid type abbreviation delcaration allowed
4 participants