Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for covering adding item templates (C# and VB) #15286

Closed

Conversation

YuliiaKovalova
Copy link
Member

@YuliiaKovalova YuliiaKovalova commented Jan 16, 2023

Add tests for covering class item templates (C# and VB)
The item templates were introduced in the scope of #28915

dotnet-maestro bot and others added 13 commits January 13, 2023 05:11
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 7.0.200-preview.23060.2 -> To Version 7.0.200-preview.23062.25

Dependency coherency updates

Microsoft.NET.ILLink.Tasks,Microsoft.Build
 From Version 7.0.100-1.22579.2 -> To Version 7.0.100-1.23062.2 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 7.0.200-preview.23060.2 -> To Version 7.0.200-preview.23062.35

Dependency coherency updates

Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.ILLink.Tasks,Microsoft.Build
 From Version 12.5.0-beta.23059.11 -> To Version 12.5.0-beta.23062.3 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 7.0.200-preview.23060.2 -> To Version 7.0.200-preview.23063.2

Dependency coherency updates

Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.ILLink.Tasks,Microsoft.Build
 From Version 12.5.0-beta.23059.11 -> To Version 12.5.0-beta.23062.3 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 7.0.200-preview.23060.2 -> To Version 7.0.200-preview.23063.9

Dependency coherency updates

Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.ILLink.Tasks,Microsoft.Build
 From Version 12.5.0-beta.23059.11 -> To Version 12.5.0-beta.23062.3 (parent: Microsoft.NET.Sdk
…ence-packages build 20230113.1

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 7.0.0-alpha.1.22608.2 -> To Version 7.0.0-alpha.1.23063.1
test/EndToEnd/ProjectBuildTests.cs Show resolved Hide resolved
[InlineData("enum")]
[InlineData("record")]
[InlineData("interface")]
public void ItCanCreateItemTemplateWithProjectRestriction(string templateName, string language = "C#")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding at least one test for VB, and one test for default language (C#).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cases will be added when the package insertion passes
#15256

@YuliiaKovalova YuliiaKovalova changed the title add tests for covering adding item templates (C#) add tests for covering adding item templates (C# and VB) Jan 18, 2023
@YuliiaKovalova YuliiaKovalova changed the base branch from release/7.0.2xx to release/7.0.3xx January 25, 2023 11:20
@YuliiaKovalova YuliiaKovalova requested a review from a team as a code owner January 25, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.