Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[generator] Use the correct javadoc element #934

Merged
merged 1 commit into from
Dec 14, 2021

Conversation

pjcollins
Copy link
Member

Fixes: #933

Fixes a bug when attempting to find the <javadoc/> element that is
associated with a specific member name and jni-signature. When a type
contained multiple members with the same name, we would always return
the first <javadoc/> that matched the member name, rather than the
one that matched both the name and signature.

Fixes: dotnet#933

Fixes a bug when attempting to find the `<javadoc/>` element that is
associated with a specific member name and jni-signature.  When a type
contained multiple members with the same name, we would always return
the first `<javadoc/>` that matched the member name, rather than the
one that matched both the name and signature.
@pjcollins
Copy link
Member Author

Unfortunately this wasn't found before xamarin/android-api-docs#26 was merged, as this is going to produce a mostly unreviewable diff unless we want to try to update docs one type at a time:
https://gist.github.com/pjcollins/54ff5b9d40cafb4bfde606a8ef15f348

@pjcollins
Copy link
Member Author

Here is a smaller diff for ObjectAnimator.xml - https://gist.github.com/pjcollins/03777c79128302d2d08077a372e63091. There are still some issues in the generated developer.android.com links tracked in #931 and #932 that will be fixed separately.

@pjcollins pjcollins merged commit d64087c into dotnet:main Dec 14, 2021
@pjcollins pjcollins deleted the fix-jnisig-match branch December 14, 2021 20:14
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[API Docs] Invalid parameter values for certain overloads in ObjectAnimator
1 participant