[generator] Use the correct javadoc element #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#933 Fixes a bug when attempting to find the `<javadoc/>` element that is associated with a specific member name and jni-signature. When a type contained multiple members with the same name, we would always return the first `<javadoc/>` that matched the member name, rather than the one that matched both the name and signature.
|
Unfortunately this wasn't found before xamarin/android-api-docs#26 was merged, as this is going to produce a mostly unreviewable diff unless we want to try to update docs one type at a time: |
|
Here is a smaller diff for ObjectAnimator.xml - https://gist.github.com/pjcollins/03777c79128302d2d08077a372e63091. There are still some issues in the generated developer.android.com links tracked in #931 and #932 that will be fixed separately. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #933
Fixes a bug when attempting to find the
<javadoc/>element that isassociated with a specific member name and jni-signature. When a type
contained multiple members with the same name, we would always return
the first
<javadoc/>that matched the member name, rather than theone that matched both the name and signature.