This repository has been archived by the owner on May 29, 2024. It is now read-only.
Import documentation for API-31 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docs Build status updates of commit 1e61550:
|
|
Docs Build status updates of commit 7fc3d7e:
|
|
@davidbritch @jonpryor unfortunately this initial docs update is going to be mostly un-reviewable, but I think the best course of action is to land this sooner than later. This update will allow us to iterate on smaller fixes that will be more testable and reviewable. Commit message draft (edited from #23): |
This was referenced Nov 2, 2021
|
Docs Build status updates of commit 29477f5:
|
|
Docs Build status updates of commit 0067596:
|
|
Docs Build status updates of commit cbf096f:
|
|
Docs Build status updates of commit 7385542:
|
|
Comparing the build results from master to the latest build in this PR shows a pretty similar amount of warnings and suggestions given the scope of change, so this should be getting close. The only thing that I am curious about in the PR build summary is the fact that the "Total Files" (92216) value did not match the "Total Published Files" (92215) value. I'm not sure if this is a cause for concern. After further review of some of the changes introduced with the |
|
I don't think the total published files is a cause for concern. Aside from anything else, the total content files is 92214. |
|
Docs Build status updates of commit 03ec039:
|
|
I think this should be ready for a final (high level) review, I can squash and merge it at some point this week if there is nothing else that looks out of place. |
|
Looks good to me. I'm asking how we can default the language drop-down to C#, for new users. But that shouldn't block publishing this PR. Once it's published I'll deprecate the previous monikers. |
|
Docs Build status updates of commit 8be6c37:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces: #23
Context: dotnet/android#5485
Context: dotnet/android@a7413a2
Update the
Mono.Android.dlldocumentation, importing theGoogle-provided API-31 Javadoc documentation.
At this time, only the following documentation is imported:
<param/>: The Javadoc@paramblock tag.<returns/>: The Javadoc@returnsblock tag.<summary/>: First sentence in Javadoc comment.Additionally, the following information is generated:
Note that the link to Android documentation may not work; there are
known issues around the use of generic types.
The perfect is the enemy of the good (enough)! It's been 4+ years
since the last documentation import. Let's get something newer.