Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package props for older SDKs #2848

Merged
merged 1 commit into from
Jun 20, 2022
Merged

Conversation

sbomer
Copy link
Member

@sbomer sbomer commented Jun 17, 2022

This should keep the existing package override logic working, since
the current SDK will only import the in-box ILLink.Tasks.props if
this is not already set.

We could probably remove this once runtime is updated to use an SDK
with dotnet/sdk#25993. Or, we might want to
keep it as long as any SDKs using the old override logic are still in support.
This would let them reference newer ILLink.Tasks packages as long as
the task surface doesn't contain breaking changes (like new required parameters).

This should keep the existing package override logic working, since
the current SDK will only import the in-box ILLink.Tasks.props if
this is not already set.
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice catch

@sbomer sbomer merged commit 3f3da1d into dotnet:main Jun 20, 2022
agocke pushed a commit to dotnet/runtime that referenced this pull request Nov 16, 2022
This should keep the existing package override logic working, since
the current SDK will only import the in-box ILLink.Tasks.props if
this is not already set.

Commit migrated from dotnet/linker@3f3da1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants