-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ILLink targets to the linker repo #25993
Conversation
This will keep the ILLink task and targets in-sync.
I think there's some potential simplification here by getting rid of the "SDK" stuff entirely. Just |
@dsplaisted Is there any benefit to the "Sdk" login in MSBuild for these built-in components? It seems like it's just a space/time saver for people typing project files manually. |
@MichalStrehovsky FYI, in case this conflicts with anything you're thinking. I was planning on extracting trimming pieces that are shared between NativeAOT and ILLink into the central publish targets (like the feature switches). |
Looks good to me. We should do the ILLinkTargetPath for NativeAOT targets as well. (Not really a comment for this pull request, just an observation.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the effort to keep in sync as well streamline common actions between NativeAOT
and Trimming
. I'm assuming that the existing tests we have for both NativeAOT
and Trimming
in the SDK will guard against regression here.
Yup, I'm aiming for no functional change here. |
This will keep the ILLink task and targets in-sync.