Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken inheritance from DataFrameColumn class #7324

Conversation

asmirnov82
Copy link
Contributor

Fixes #7323

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.88%. Comparing base (cfc1fb5) to head (798bde9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...sis/DataFrameColumns/ArrowStringDataFrameColumn.cs 0.00% 1 Missing ⚠️
...nalysis/DataFrameColumns/VBufferDataFrameColumn.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7324   +/-   ##
=======================================
  Coverage   68.88%   68.88%           
=======================================
  Files        1470     1470           
  Lines      274005   274005           
  Branches    28403    28403           
=======================================
+ Hits       188736   188739    +3     
+ Misses      77950    77949    -1     
+ Partials     7319     7317    -2     
Flag Coverage Δ
Debug 68.88% <0.00%> (+<0.01%) ⬆️
production 63.29% <0.00%> (+<0.01%) ⬆️
test 89.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Microsoft.Data.Analysis/DataFrameColumn.cs 65.46% <ø> (ø)
...Analysis/DataFrameColumns/StringDataFrameColumn.cs 68.15% <ø> (ø)
...oft.Data.Analysis/PrimitiveDataFrameColumn.Sort.cs 87.80% <ø> (ø)
...sis/DataFrameColumns/ArrowStringDataFrameColumn.cs 59.16% <0.00%> (ø)
...nalysis/DataFrameColumns/VBufferDataFrameColumn.cs 44.57% <0.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Member

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick fix!

@michaelgsharp
Copy link
Member

Merging on red as test failures are known issues not related to this PR and we don't have BuildAnalysis set up yet to green the checks yet.

@michaelgsharp michaelgsharp merged commit 12411fc into dotnet:main Nov 27, 2024
21 of 25 checks passed
@asmirnov82 asmirnov82 deleted the 7323_fix_broken_dtaframecolumn_inheritance branch November 27, 2024 17:59
asmirnov82 added a commit to asmirnov82/machinelearning that referenced this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can no longer subclass DataFrameColumn due to internal abstract GetSortIndices method
2 participants