Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken inheritance from DataFrameColumn class (#7324) #7331

Merged

Conversation

asmirnov82
Copy link
Contributor

Backport #7324 to release 4.0.1

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.88%. Comparing base (d92c0b3) to head (b351e33).
Report is 2 commits behind head on release/4.0.

Files with missing lines Patch % Lines
...sis/DataFrameColumns/ArrowStringDataFrameColumn.cs 0.00% 1 Missing ⚠️
...nalysis/DataFrameColumns/VBufferDataFrameColumn.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           release/4.0    #7331   +/-   ##
============================================
  Coverage        68.87%   68.88%           
============================================
  Files             1470     1470           
  Lines           274003   274003           
  Branches         28403    28403           
============================================
+ Hits            188716   188739   +23     
+ Misses           77967    77948   -19     
+ Partials          7320     7316    -4     
Flag Coverage Δ
Debug 68.88% <0.00%> (+<0.01%) ⬆️
production 63.29% <0.00%> (+<0.01%) ⬆️
test 89.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Microsoft.Data.Analysis/DataFrameColumn.cs 65.46% <ø> (ø)
...Analysis/DataFrameColumns/StringDataFrameColumn.cs 68.15% <ø> (ø)
...oft.Data.Analysis/PrimitiveDataFrameColumn.Sort.cs 87.80% <ø> (ø)
...sis/DataFrameColumns/ArrowStringDataFrameColumn.cs 59.16% <0.00%> (ø)
...nalysis/DataFrameColumns/VBufferDataFrameColumn.cs 44.57% <0.00%> (ø)

... and 4 files with indirect coverage changes

@ericstj
Copy link
Member

ericstj commented Dec 16, 2024

It looks like we are only running APICompat for stable projects --

<PackageValidationBaselineVersion>$([MSBuild]::Subtract($(MajorVersion), 1)).0.0</PackageValidationBaselineVersion>

We should probably enable that for all of them. We still want to know when we break the others.

@ericstj ericstj merged commit 05c66e6 into dotnet:release/4.0 Dec 16, 2024
25 checks passed
@asmirnov82 asmirnov82 deleted the backport/pr-7324-to-release/4.0 branch December 17, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants