-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update semantics #1039
Update semantics #1039
Conversation
@@ -55,18 +55,18 @@ | |||
SemanticProperties.Hint="Hint text"/> | |||
|
|||
<Entry | |||
Text="Entry text TH" | |||
Text="Entry text, iOS:DTH, Android:TH" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how these read on XCT?
Like if we use the AccessibilityDelegate instead of the content description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It reads the same on XCT at the moment
@@ -83,6 +83,8 @@ public static void UpdateSemantics(this UIView nativeView, IView view) | |||
|
|||
if (semantics == null) | |||
return; | |||
else | |||
nativeView.IsAccessibilityElement = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should only get set if there's an actual value set for Description/Hint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing now - but can you remind me why the null check is sufficient for Android and not iOS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That statement applies to both Android and iOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotcha - will fix both here and in XCT soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on our conversations we need to fix Android to read out like iOS with the Entry control
bf4eb2f
to
4e37082
Compare
…dit-semantics-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a layout example so we can see the behaviors on a layout
<stacklayout SemanticProperty.Description="Hello">
<label
<button
<stacklayout SemanticProperty.Description="Hello">
<label
<label
[Fact(DisplayName = "Semantic Description is set correctly")] | ||
[Fact(DisplayName = "Semantic Description is set correctly" | ||
#if MONOANDROID | ||
, Skip = "This value can't be validated through automated tests" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we switched to using delegates for reading out the semantic description we can no longer verify these values through unit tests
Description of Change
PR Checklist
Does this PR touch anything that might affect accessibility?
If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.