-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update semantics #1039
Merged
Merged
Update semantics #1039
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
3588d7a
Update semantics page
rachelkang 521d804
Controls w/ semantics should automatically be in semantic tree
rachelkang 8021dbd
iOS image is now accessible
rachelkang 3d93fa0
Make iOS view accessible specifically w/ hint/desc
rachelkang e539147
code clean up
rachelkang e3ae219
Make importantForAccessibility conditional on hint/desc
rachelkang bf4eb2f
Make SemanticsPage heading read more accessibly
rachelkang d4b2b48
Update semantics page
rachelkang 17edc9c
Controls w/ semantics should automatically be in semantic tree
rachelkang d6889d0
iOS image is now accessible
rachelkang 2c34f0f
Make iOS view accessible specifically w/ hint/desc
rachelkang 3abdd94
code clean up
rachelkang 91ab624
Make importantForAccessibility conditional on hint/desc
rachelkang 4e37082
Make SemanticsPage heading read more accessibly
rachelkang eb76f61
Merge branch 'audit-semantics-page' of github.com:dotnet/maui into au…
rachelkang 8aabfcc
Update Android semantics to use accessibilityDelegate
rachelkang 1bf9152
Make description read from Android EditText
rachelkang 27c94c2
Fix conflicting accessibilityDelegate code weirdness
rachelkang ea15723
Update SemanticsPage to reflect EditText updates
rachelkang ebd5517
Update Picker text to reflect Android's identical behavior
rachelkang 82e669e
Add sample StackLayouts with semantics
rachelkang 9d4d0f9
Fix typo
rachelkang 558be5f
- fix searchview
PureWeen b6679bc
Update SemanticsPage - reflect current SearchBar behavior
rachelkang 3e28c30
- API 26 workarounds
PureWeen 597a5fb
- fix pre-api 26 for non text views
PureWeen fe7e92b
Merge branch 'main' into audit-semantics-page
PureWeen 26d8306
- skip android tests
PureWeen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we switched to using delegates for reading out the semantic description we can no longer verify these values through unit tests