Fix iOS ListView cell gone hidden (#11287) #13669

ooikengsiang · 2023-03-03T08:02:29Z

Description of Change

Workaround iOS / MacOS ListView cell disappear when user scroll back and DequeueReusableCell return a hidden cell.
Force any hidden cell return by DequeueReusableCell which are hidden to create a new cell instead (set hidden to false doesn't work).

Issues Fixed

Fixes #11287

Workaround iOS ListView cell disappear when user scroll back and DequeueReusableCell return a hidden cell

ghost · 2023-03-03T08:02:37Z

Hey there @ooikengsiang! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

ooikengsiang · 2023-03-03T08:03:32Z

@dotnet-policy-service agree

ooikengsiang · 2023-03-03T08:04:46Z

@ooikengsiang please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@dotnet-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"
Contributor License Agreement

@dotnet-policy-service agree

jfversluis · 2023-03-03T14:07:23Z

/azp run

azure-pipelines · 2023-03-03T14:07:42Z

Azure Pipelines successfully started running 2 pipeline(s).

mandel-macaque

Minor nit, we are trying to move away from '== null' and '!= null'. Thanks for the fix!

src/Controls/src/Core/Compatibility/Handlers/ListView/iOS/CellTableViewCell.cs

…TableViewCell.cs Co-authored-by: Manuel de la Pena <mandel@microsoft.com>

rmarinho · 2023-03-06T11:41:52Z

src/Controls/src/Core/Compatibility/Handlers/ListView/iOS/CellTableViewCell.cs

+			{
+				// set hidden to false doesn't work
+				// force recreate of the whole cell instead
+				reusableCell = null;


won't this break all cell reuse?

No, because those cell return that are not hidden are perfectly fine to reuse. Only those hidden are not. Also, I point out that setting hidden to false doesn't fix it. This may not be a perfect fix, but currently this fix at least make the ListView work correctly.

azure-pipelines · 2023-03-08T13:02:51Z

Azure Pipelines successfully started running 2 pipeline(s).

PureWeen

@ooikengsiang Not sure if I'm missing something but I think the wrong reproduction was uploaded to the original issue? https://github.com/ooikengsiang/ListViewProblem ?

Can you point me to a reproduction of the issue so that I can test your fix?

Symbai · 2023-03-10T01:25:14Z

@PureWeen I have a repro here: #13633 which might be the same issue, it was also linked with the original issue. The only difference is that in my issue cells become hidden when app goes into background and come back while in the original issue its when scrolling through the list. But the result is the same, cells become hidden.

ooikengsiang · 2023-03-10T04:01:51Z

@ooikengsiang Not sure if I'm missing something but I think the wrong reproduction was uploaded to the original issue? https://github.com/ooikengsiang/ListViewProblem ?

Can you point me to a reproduction of the issue so that I can test your fix?

Fixed, sorry for the mix up.

matmork · 2023-04-08T16:40:13Z

👀

PureWeen

I think the main problem here is that the viewhandler on the ViewCellRenderer isn't being completely disconnected.

I've checked in an alternate approach here
https://github.com/dotnet/maui/tree/13669_testing

can you let me know how that works for you? if that seems to address the problem?

ooikengsiang · 2023-05-11T14:56:45Z

I think the main problem here is that the viewhandler on the ViewCellRenderer is being completely disconnected.

I've checked in an alternate approach here https://github.com/dotnet/maui/tree/13669_testing

can you let me know how that works for you? if that seems to address the problem?

Let me check and will get back to you.

PureWeen · 2023-05-11T14:58:44Z

I think the main problem here is that the viewhandler on the ViewCellRenderer isn't being completely disconnected.

FYI, I meant to say isn't being disconnected.

I think the main problem here is that the viewhandler on the ViewCellRenderer isn't being completely disconnected.

ooikengsiang · 2023-05-11T15:33:35Z

I think the main problem here is that the viewhandler on the ViewCellRenderer isn't being completely disconnected.

FYI, I meant to say isn't being disconnected.

I think the main problem here is that the viewhandler on the ViewCellRenderer isn't being completely disconnected.

Test and it work! Awesome, never know that disconnect is required there.
Thanks for spending extra time looking into this.

PureWeen · 2023-05-11T17:11:00Z

Thank you for testing @ooikengsiang and narrowing down to where this was being quirky!

Closing this PR in favor of #15036

PureWeen · 2023-05-16T01:19:14Z

Thank you for testing @ooikengsiang and narrowing down to where this was being quirky!

Closing this PR in favor of #15036

@ooikengsiang if you have time can you test my updates here?

#15036

I think I was also breaking recycling with my changes :-)

I tried your repro and a few of our samples and they seemed to work fine.

Fix iOS ListView cell gone hidden (dotnet#11287)

c637e71

Workaround iOS ListView cell disappear when user scroll back and DequeueReusableCell return a hidden cell

ghost added the community ✨ Community Contribution label Mar 3, 2023

jsuarezruiz added platform/iOS 🍎 area-controls-listview ListView and TableView labels Mar 3, 2023

mandel-macaque requested changes Mar 3, 2023

View reviewed changes

src/Controls/src/Core/Compatibility/Handlers/ListView/iOS/CellTableViewCell.cs Outdated Show resolved Hide resolved

matmork mentioned this pull request Mar 3, 2023

ListView ViewCell content disappears when the application enters the foreground #11640

Closed

Update src/Controls/src/Core/Compatibility/Handlers/ListView/iOS/Cell…

888d43f

…TableViewCell.cs Co-authored-by: Manuel de la Pena <mandel@microsoft.com>

rmarinho reviewed Mar 6, 2023

View reviewed changes

PureWeen self-assigned this Mar 6, 2023

PureWeen requested changes Mar 9, 2023

View reviewed changes

jfversluis requested a review from PureWeen March 17, 2023 10:08

PureWeen mentioned this pull request May 3, 2023

Visual Element gets duplicated after TableView is refreshed #14819

Closed

PureWeen requested a review from mandel-macaque May 9, 2023 16:30

PureWeen requested changes May 10, 2023

View reviewed changes

PureWeen closed this May 11, 2023

JohnHDev mentioned this pull request Jul 14, 2023

.NET MAUI Android ListView issues #16137

Open

github-actions bot locked and limited conversation to collaborators Dec 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix iOS ListView cell gone hidden (#11287) #13669

Fix iOS ListView cell gone hidden (#11287) #13669

ooikengsiang commented Mar 3, 2023

ghost commented Mar 3, 2023

ooikengsiang commented Mar 3, 2023

ooikengsiang commented Mar 3, 2023

jfversluis commented Mar 3, 2023 •

edited

Loading

azure-pipelines bot commented Mar 3, 2023

mandel-macaque left a comment

rmarinho Mar 6, 2023

ooikengsiang Mar 6, 2023

azure-pipelines bot commented Mar 8, 2023

PureWeen left a comment

Symbai commented Mar 10, 2023

ooikengsiang commented Mar 10, 2023

matmork commented Apr 8, 2023

PureWeen left a comment •

edited

Loading

ooikengsiang commented May 11, 2023

PureWeen commented May 11, 2023

ooikengsiang commented May 11, 2023 •

edited

Loading

PureWeen commented May 11, 2023

PureWeen commented May 16, 2023

Fix iOS ListView cell gone hidden (#11287) #13669

Fix iOS ListView cell gone hidden (#11287) #13669

Conversation

ooikengsiang commented Mar 3, 2023

Description of Change

Issues Fixed

ghost commented Mar 3, 2023

ooikengsiang commented Mar 3, 2023

ooikengsiang commented Mar 3, 2023

jfversluis commented Mar 3, 2023 • edited Loading

azure-pipelines bot commented Mar 3, 2023

mandel-macaque left a comment

Choose a reason for hiding this comment

rmarinho Mar 6, 2023

Choose a reason for hiding this comment

ooikengsiang Mar 6, 2023

Choose a reason for hiding this comment

azure-pipelines bot commented Mar 8, 2023

PureWeen left a comment

Choose a reason for hiding this comment

Symbai commented Mar 10, 2023

ooikengsiang commented Mar 10, 2023

matmork commented Apr 8, 2023

PureWeen left a comment • edited Loading

Choose a reason for hiding this comment

ooikengsiang commented May 11, 2023

PureWeen commented May 11, 2023

ooikengsiang commented May 11, 2023 • edited Loading

PureWeen commented May 11, 2023

PureWeen commented May 16, 2023

jfversluis commented Mar 3, 2023 •

edited

Loading

PureWeen left a comment •

edited

Loading

ooikengsiang commented May 11, 2023 •

edited

Loading