Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove incorrect call to DisconnectHandler #15036

Merged
merged 2 commits into from
May 18, 2023
Merged

Remove incorrect call to DisconnectHandler #15036

merged 2 commits into from
May 18, 2023

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented May 11, 2023 •
edited by samhouts
Loading

Description of Change

When I initially tried to fix an issue where the wrong virtual view was getting assigned to the wrong view cell, I did so by disconnecting the ViewCell at the wrong point in time. This PR moves the disconnect to the point in type when the ViewCell is being used for recycling.

Issues Fixed

Fixes #11287
Fixes #11640

@PureWeen PureWeen mentioned this pull request May 11, 2023
Closed
@PureWeen PureWeen changed the title Clear out the renderer on VCR when disconnected Remove incorrect call to DisconnectHandler May 16, 2023
@ooikengsiang
Copy link
Contributor

This changes seem way more reasonable.
Base on my limited testing, they work correctly.

@PureWeen
Copy link
Member Author

This changes seem way more reasonable. Base on my limited testing, they work correctly.

Perfect! Thank you as always!!

@PureWeen PureWeen marked this pull request as ready for review May 16, 2023 14:37
@rmarinho
Copy link
Member

But now cell.Handler?.DisconnectHandler() is never called right?

@PureWeen
Copy link
Member Author

But now cell.Handler?.DisconnectHandler() is never called right?

It's called from here when the ViewCell is swapped out.

@mattleibow mattleibow merged commit 99a7b04 into main May 18, 2023
@mattleibow mattleibow deleted the fix_11287 branch May 18, 2023 21:06
rmarinho pushed a commit that referenced this pull request May 30, 2023
@PureWeen @rmarinho
Remove incorrect call to DisconnectHandler (#15036)
ae41643
This was referenced Jul 4, 2023
Closed
Closed
@mattleibow mattleibow added the backport/suggested The PR author or issue review has suggested that the change should be backported. label Jul 13, 2023
@rachelkang rachelkang mentioned this pull request Jul 17, 2023
Open
@PureWeen PureWeen added the backport/NO This change should not be backported. It may break customers. label Jul 26, 2023
@drasticactions drasticactions mentioned this pull request Aug 11, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattleibow mattleibow mattleibow approved these changes

Assignees
No one assigned
Labels
backport/NO This change should not be backported. It may break customers. backport/suggested The PR author or issue review has suggested that the change should be backported. fixed-in-8.0.0-preview.5.8529 Look for this fix in 8.0.0-preview.5.8529!
Projects
None yet
Milestone
No milestone
5 participants
@PureWeen @ooikengsiang @rmarinho @mattleibow @samhouts