Fix ContentView RTL #15114
Merged
Fix ContentView RTL #15114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
the
area-layout
hartez
force-pushed
the
fix_contentview_rtl
branch
from
1f6e35c
to
a54abef
Compare
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
mattleibow
approved these changes
May 18, 2023
|
Thanks @PureWeen for the fix, is this going to be backported to net7? it's a big issue that impacts all apps using RTL. |
mattleibow
added
the
backport/suggested
rmarinho
pushed a commit
that referenced
this pull request
May 30, 2023
* Avoid negative X position values when arranging for RTL Fixes #15095 * Add automated test * Auto-format source code --------- Co-authored-by: E.Z. Hart <hartez@gmail.com> Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com>
hartez
added
the
backport/NO
samhouts
added
the
fixed-in-8.0.0-preview.5.8529
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The logic in the iOS platform arrangement handler has faulty logic which sometimes gives child views negative X positions within their parent views; this happens when the flow direction is set to RTL and it makes the child views disappear.
These changes fix the logic to avoid disappearing the views and adds an automated test to guard against this in the future.
Issues Fixed
Fixes #15095