Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PickerHandler in WinUI #779

Merged
merged 11 commits into from
Apr 27, 2021
Merged

Implement PickerHandler in WinUI #779

merged 11 commits into from
Apr 27, 2021

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Implement PickerHandler in WinUI

  • ItemsSource
  • SelectedIndex
  • Title
  • TextColor
  • Font
  • CharacterSpacing

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might effect accessibility?

No

@rachelkang rachelkang self-requested a review April 22, 2021 21:21
rachelkang
rachelkang reviewed Apr 22, 2021
View reviewed changes
Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Picker is rendering weirdly:

image

rmarinho
rmarinho requested changes Apr 26, 2021
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the picker is not rendering as expected

image

Should renderer something like:

image
image

@jsuarezruiz
Copy link
Contributor Author

@rachelkang Could you try again?
winui-picker

@rmarinho
Copy link
Member

@jsuarezruiz how do i see other Font?

image

@rmarinho
Copy link
Member

Oh ok the sample was setting the font :)

image

@rmarinho rmarinho self-requested a review April 26, 2021 13:22
rachelkang
rachelkang requested changes Apr 26, 2021
View reviewed changes
Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now, but I think the title should be inside the ComboBox too, not above it

image

src/Core/src/Platform/Windows/MauiCombobox.cs

namespace Microsoft.Maui
{
public class MauiComboBox : ComboBox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name should also be MauiComboBox.cs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

src/Core/src/Platform/Windows/PickerExtensions.cs Outdated Show resolved Hide resolved
@rmarinho
Copy link
Member

@rachelkang if you check UWP on Xamarin Forms the title is above..

image

@rachelkang
Copy link
Member

@rachelkang if you check UWP on Xamarin Forms the title is above..

image

ah, ok. I guess I misremembered seeing otherwise - thanks!

rachelkang
rachelkang approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@rachelkang rachelkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after MauiComboBox file rename!

@jsuarezruiz
Copy link
Contributor Author

@rachelkang Updated the PickerExtensions to change the wrong ComboBox type to MauiComboBox.

@jsuarezruiz jsuarezruiz merged commit ec5f630 into main Apr 27, 2021
@jsuarezruiz jsuarezruiz deleted the winui-picker branch April 27, 2021 14:40
Redth added a commit that referenced this pull request Apr 28, 2021
@mgoertz-msft @rmarinho
@github-actions @dotnet-maestro @PureWeen @mattleibow @Clancey @jsuarezruiz @rachelkang @jonathanpeppers @1d0n7kn0w @Redth
Bring back XAML2006/2009 XmlnsDefinition attributes (#878)
4f8ee0f 
* Fix yaml triggers

* Run pr's for release branches

* Automated dotnet-format update (#839)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* [Housekeeping] Add provisionating xcode to net6 (#836)

* Add provisionating xcode to net6

* Fix essentials device tests

* try again

* Update dependencies from https://github.com/xamarin/xamarin-android build main-a2156d41275b92de3cf23f7c79801327c74b7fe0-1 (#846)

Microsoft.Android.Sdk.Windows
 From Version 11.0.200-ci.main.226 -> To Version 11.0.200-ci.main.234

Dependency coherency updates

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.100-preview.4.21215.1 -> To Version 6.0.100-preview.4.21221.10 (parent: Microsoft.Android.Sdk.Windows

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* WinUI Navigation Handler (#801)

* WinUI Navigation Handler

* - PR comments

* - consolidate a few more APIs

* - fix namespaces

* - fix namespaces

* Update src/Compatibility/Core/src/WinUI/FlyoutPageRenderer.cs

Co-authored-by: Matthew Leibowitz <mattleibow@live.com>

Co-authored-by: Matthew Leibowitz <mattleibow@live.com>

* Improve Hot Reload Integration (#851)

* Fixes HotReload (#853)

Reverts changed from: 7d4d1ce#diff-2b4bb95e12307423f7126d91b43a1511b68d00535e9f2b5f535af85d7a388333R36

* Android Push/Pop Navigation (#837)

* Android Navigation

* - fix layout

* - changes

* - yay pushing

* - wire up nav to use bundle ids

* - cleanup

* - setup pop

* - build up nav stack

* - remove nav push

* - remove graph xml

* Update global.json

* - add android to non net6 controls project

* - fix namespace

* Update Microsoft.Maui-net6.sln

* iOS NavigationPageHandler (#852)

* iOS Navigation

* - wire up iOS Navigation

* - remove VET

* - rework with HR

* - fix namespace

* - fix HR

* - fix hr

* - fix SO exception

* - maybe?

* - nullabel fix

* Update dependencies from https://github.com/xamarin/xamarin-macios build 20210426.5 (#847)

Microsoft.MacCatalyst.Sdk , Microsoft.iOS.Sdk
 From Version 14.5.100-ci.main.620 -> To Version 14.5.100-ci.main.658

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Rui Marinho <me@ruimarinho.net>

* Automated dotnet-format update (#854)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Implement PickerHandler in WinUI (#779)

* Implement PickerHandler in WinUI

* Enab le nullable in some classes

* Fix build error

* Register MauiComboBox ResourceDictionary

* Updated PickerExtensions

* Updated MauiComboBox

Co-authored-by: Rachel Kang <rachelkang@microsoft.com>

* [Build] Update maestro with macOS and tvOS (#862)

* [Build] Update maestro with macOS and tvOS

* [Build] Add tvOS and macOS to workload/dogfood

* Add Microsoft.iOS.Windows.Sdk

Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>

* Update README.md (#865)

* ContainerViewControllers should use the correct background color. (#868)

Also set the title of the VC from a page

* Automated dotnet-format update (#872)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Bring back XAML2006/2009 XmlnsDefinition attributes

These are required so that things like x:Static can be resolved to Microsoft.Maui.Controls.Xaml.StaticExtension.

Co-authored-by: Rui Marinho <me@ruimarinho.net>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
Co-authored-by: James Clancey <james.clancey@gmail.com>
Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>
Co-authored-by: Rachel Kang <rachelkang@microsoft.com>
Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
Co-authored-by: 1d0n7kn0w <3910210+1d0n7kn0w@users.noreply.github.com>
Co-authored-by: Jonathan Dick <jodick@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@rachelkang rachelkang rachelkang approved these changes

Assignees
No one assigned
Labels
fixed-in-6.0.100-preview.4.1 platform/windows 🪟
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsuarezruiz @rmarinho @rachelkang @samhouts