Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS NavigationPageHandler #852

Merged
merged 10 commits into from
Apr 27, 2021
Merged

iOS NavigationPageHandler #852

merged 10 commits into from
Apr 27, 2021

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Apr 26, 2021

Description of Change

Implements basic push/pop on iOS

  • I added a Maui.iOS.sln that is setup to only build the "Xamarin.iOS" targets. This makes the building and running of iOS a lot quicker and more predictable
  • The implementation for pushing and popping was mainly taken from the shell implementation of UINavigationController because it seems a bit more up to date and streamlined. It also handles cancelling once we cross that bridge.

Additions made

  • IViewHandler.ViewController - this allows ViewHandlers to define a viewcontroller for themselves

@PureWeen PureWeen marked this pull request as ready for review April 26, 2021 23:08
@PureWeen PureWeen changed the title Ios navigation iOS NavigationPageHandler Apr 26, 2021
Base automatically changed from android_navigation to main April 27, 2021 02:22
@PureWeen PureWeen merged commit 65a4499 into main Apr 27, 2021
@PureWeen PureWeen deleted the ios_navigation branch April 27, 2021 04:04
PureWeen added a commit that referenced this pull request Apr 27, 2021
* iOS Navigation

* - wire up iOS Navigation

* - remove VET

* - rework with HR

* - fix namespace

* - fix HR

* - fix hr

* - fix SO exception

* - maybe?

* - nullabel fix
rmarinho pushed a commit that referenced this pull request Apr 27, 2021
* WinUI Navigation Handler (#801)

* WinUI Navigation Handler

* - PR comments

* - consolidate a few more APIs

* - fix namespaces

* - fix namespaces

* Update src/Compatibility/Core/src/WinUI/FlyoutPageRenderer.cs

Co-authored-by: Matthew Leibowitz <mattleibow@live.com>

Co-authored-by: Matthew Leibowitz <mattleibow@live.com>

* Improve Hot Reload Integration (#851)

* Fixes HotReload (#853)

Reverts changed from: 7d4d1ce#diff-2b4bb95e12307423f7126d91b43a1511b68d00535e9f2b5f535af85d7a388333R36

* Android Push/Pop Navigation (#837)

* Android Navigation

* - fix layout

* - changes

* - yay pushing

* - wire up nav to use bundle ids

* - cleanup

* - setup pop

* - build up nav stack

* - remove nav push

* - remove graph xml

* Update global.json

* - add android to non net6 controls project

* - fix namespace

* Update Microsoft.Maui-net6.sln

* iOS NavigationPageHandler (#852)

* iOS Navigation

* - wire up iOS Navigation

* - remove VET

* - rework with HR

* - fix namespace

* - fix HR

* - fix hr

* - fix SO exception

* - maybe?

* - nullabel fix

Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
Co-authored-by: James Clancey <james.clancey@gmail.com>
Redth added a commit that referenced this pull request Apr 28, 2021
* Fix yaml triggers

* Run pr's for release branches

* Automated dotnet-format update (#839)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* [Housekeeping] Add provisionating xcode to net6 (#836)

* Add provisionating xcode to net6

* Fix essentials device tests

* try again

* Update dependencies from https://github.com/xamarin/xamarin-android build main-a2156d41275b92de3cf23f7c79801327c74b7fe0-1 (#846)

Microsoft.Android.Sdk.Windows
 From Version 11.0.200-ci.main.226 -> To Version 11.0.200-ci.main.234

Dependency coherency updates

Microsoft.Dotnet.Sdk.Internal
 From Version 6.0.100-preview.4.21215.1 -> To Version 6.0.100-preview.4.21221.10 (parent: Microsoft.Android.Sdk.Windows

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>

* WinUI Navigation Handler (#801)

* WinUI Navigation Handler

* - PR comments

* - consolidate a few more APIs

* - fix namespaces

* - fix namespaces

* Update src/Compatibility/Core/src/WinUI/FlyoutPageRenderer.cs

Co-authored-by: Matthew Leibowitz <mattleibow@live.com>

Co-authored-by: Matthew Leibowitz <mattleibow@live.com>

* Improve Hot Reload Integration (#851)

* Fixes HotReload (#853)

Reverts changed from: 7d4d1ce#diff-2b4bb95e12307423f7126d91b43a1511b68d00535e9f2b5f535af85d7a388333R36

* Android Push/Pop Navigation (#837)

* Android Navigation

* - fix layout

* - changes

* - yay pushing

* - wire up nav to use bundle ids

* - cleanup

* - setup pop

* - build up nav stack

* - remove nav push

* - remove graph xml

* Update global.json

* - add android to non net6 controls project

* - fix namespace

* Update Microsoft.Maui-net6.sln

* iOS NavigationPageHandler (#852)

* iOS Navigation

* - wire up iOS Navigation

* - remove VET

* - rework with HR

* - fix namespace

* - fix HR

* - fix hr

* - fix SO exception

* - maybe?

* - nullabel fix

* Update dependencies from https://github.com/xamarin/xamarin-macios build 20210426.5 (#847)

Microsoft.MacCatalyst.Sdk , Microsoft.iOS.Sdk
 From Version 14.5.100-ci.main.620 -> To Version 14.5.100-ci.main.658

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Rui Marinho <me@ruimarinho.net>

* Automated dotnet-format update (#854)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Implement PickerHandler in WinUI (#779)

* Implement PickerHandler in WinUI

* Enab le nullable in some classes

* Fix build error

* Register MauiComboBox ResourceDictionary

* Updated PickerExtensions

* Updated MauiComboBox

Co-authored-by: Rachel Kang <rachelkang@microsoft.com>

* [Build] Update maestro with macOS and tvOS (#862)

* [Build] Update maestro with macOS and tvOS

* [Build] Add tvOS and macOS to workload/dogfood

* Add Microsoft.iOS.Windows.Sdk

Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>

* Update README.md (#865)

* ContainerViewControllers should use the correct background color. (#868)

Also set the title of the VC from a page

* Automated dotnet-format update (#872)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Bring back XAML2006/2009 XmlnsDefinition attributes

These are required so that things like x:Static can be resolved to Microsoft.Maui.Controls.Xaml.StaticExtension.

Co-authored-by: Rui Marinho <me@ruimarinho.net>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
Co-authored-by: James Clancey <james.clancey@gmail.com>
Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>
Co-authored-by: Rachel Kang <rachelkang@microsoft.com>
Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
Co-authored-by: 1d0n7kn0w <3910210+1d0n7kn0w@users.noreply.github.com>
Co-authored-by: Jonathan Dick <jodick@microsoft.com>
@samhouts samhouts added area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter area-navigation NavigationPage area-controls-pages Page types platform/android 🤖 platform/iOS 🍎 platform/windows 🪟 labels Jul 11, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 26, 2023
@Eilon Eilon removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-controls-pages Page types labels May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter area-navigation NavigationPage fixed-in-6.0.100-preview.4.1 platform/android 🤖 platform/iOS 🍎 platform/windows 🪟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants