Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance GenerateDocumentationAndConfigFiles tool to generate vNext globalconfig files #6247

Closed
mavasani opened this issue Nov 3, 2022 · 0 comments · Fixed by #6258
Closed

Enhance GenerateDocumentationAndConfigFiles tool to generate vNext globalconfig files #6247

mavasani opened this issue Nov 3, 2022 · 0 comments · Fixed by #6258
Assignees
@mavasani
Labels
Area-Infrastructure Feature Request Reliability Indicates a reliability issue (crash/data loss/test flakiness) Urgency-Soon
Milestone
VS vNext

Comments

@mavasani
Copy link
Contributor

mavasani commented Nov 3, 2022 •
edited
Loading

As a side note, I am going to enhance the tooling so such a regression does not happen in future. Our generated globalconfig files that we ship in the package should most likely include a vNext set of globalconfig files so that when the analysis level is set to latest or explicitly to vNext, we still find a proper mapped globalconfig file.

Originally posted by @mavasani in #6245 (comment)
@mavasani mavasani self-assigned this Nov 3, 2022
@mavasani mavasani added Feature Request Urgency-Soon Reliability Indicates a reliability issue (crash/data loss/test flakiness) Area-Infrastructure labels Nov 3, 2022
@mavasani mavasani added this to the 17.5 P1 milestone Nov 3, 2022
This was referenced Nov 3, 2022
Closed
Merged
@mavasani mavasani changed the title Enhance GenerateDocumentationAndConfigFiles tool to generate vNext editorconfig files Enhance GenerateDocumentationAndConfigFiles tool to generate vNext globalconfig files Nov 11, 2022
mavasani added a commit to mavasani/roslyn-analyzers that referenced this issue Nov 11, 2022
@mavasani
Enhance GenerateDocumentationAndConfigFiles tool to generate vNext gl…
00c98ef 
…obalconfig files

Fixes dotnet#6247

Our generated globalconfig files that we ship in the analyzer NuGet packages and .NET SDK should likely include a vNext set of globalconfig files so that when the analysis level is set to latest or explicitly to vNext for upcoming .NET Release, we still find a proper mapped globalconfig file. This will avoid regressions such as dotnet#6245 in future.

Verified that locally built Microsoft.CodeAnalysis.NetAnalyzers package with this change includes globalconfig files specific to 8.0 release version.
mavasani added a commit to mavasani/roslyn-analyzers that referenced this issue Nov 11, 2022
@mavasani
Enhance GenerateDocumentationAndConfigFiles tool to generate vNext gl…
5721151 
…obalconfig files

Fixes dotnet#6247

Our generated globalconfig files that we ship in the analyzer NuGet packages and .NET SDK should likely include a vNext set of globalconfig files so that when the analysis level is set to latest or explicitly to vNext for upcoming .NET Release, we still find a proper mapped globalconfig file. This will avoid regressions such as dotnet#6245 in future.

Verified that locally built Microsoft.CodeAnalysis.NetAnalyzers package with this change includes globalconfig files specific to 8.0 release version.
@mavasani mavasani mentioned this issue Nov 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mavasani mavasani

Labels
Area-Infrastructure Feature Request Reliability Indicates a reliability issue (crash/data loss/test flakiness) Urgency-Soon
Projects
None yet
Milestone
VS vNext
1 participant
@mavasani