-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance GenerateDocumentationAndConfigFiles tool to generate vNext globalconfig files #6258
Conversation
…obalconfig files Fixes dotnet#6247 Our generated globalconfig files that we ship in the analyzer NuGet packages and .NET SDK should likely include a vNext set of globalconfig files so that when the analysis level is set to latest or explicitly to vNext for upcoming .NET Release, we still find a proper mapped globalconfig file. This will avoid regressions such as dotnet#6245 in future. Verified that locally built Microsoft.CodeAnalysis.NetAnalyzers package with this change includes globalconfig files specific to 8.0 release version.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6258 +/- ##
==========================================
+ Coverage 96.04% 96.06% +0.01%
==========================================
Files 1360 1364 +4
Lines 312225 313686 +1461
Branches 10047 10125 +78
==========================================
+ Hits 299889 301330 +1441
- Misses 9928 9937 +9
- Partials 2408 2419 +11 |
@Evangelink @Youssef1313 can you please review? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - few nitpicks you can ignore if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mavasani Took a look again at this, I'm not sure how this prevents the issue in the future.
The meaning of latest
in analysis level is hardcoded to a specific version on dotnet/sdk
So the new globalconfig that contains unshipped will not be used.
This is also currently confusing. I think Please correct me if I'm misunderstanding something. |
@Youssef1313 This change basically gives us a bit of leeway when the unshipped rules get moved to the AnalyzerReases.Shipped.txt file. |
Fixes #6247
Our generated globalconfig files that we ship in the analyzer NuGet packages and .NET SDK should likely include a vNext set of globalconfig files so that when the analysis level is set to latest or explicitly to vNext for upcoming .NET Release, we still find a proper mapped globalconfig file. This will avoid regressions such as #6245 in future.
Verified that locally built Microsoft.CodeAnalysis.NetAnalyzers package with this change includes globalconfig files specific to 8.0 release version.