Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rule CA2109 #6198

Merged
merged 2 commits into from
Dec 16, 2022
Merged

Remove rule CA2109 #6198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
932604d
Remove CA2109 (#5974)
x789 Dec 13, 2022
63c4dcf
Remove resources of rule CA2109
x789 Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions ...crosoft.CodeQuality.Analyzers/QualityGuidelines/CSharpReviewVisibleEventHandlers.Fixer.cs
View file
Open in desktop

This file was deleted.

6 changes: 6 additions & 0 deletions src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,9 @@ CA1512 | Maintainability | Info | UseExceptionThrowHelpers, [Documentation](http
CA1513 | Maintainability | Info | UseExceptionThrowHelpers, [Documentation](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1513)
CA1856 | Performance | Error | ConstantExpectedAnalyzer, [Documentation](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1856)
CA1857 | Performance | Warning | ConstantExpectedAnalyzer, [Documentation](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1857)

### Removed Rules

Rule ID | Category | Severity | Notes
--------|----------|----------|-------
CA2109 | Security | Disabled | ReviewVisibleEventHandlersAnalyzer, [Documentation](https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2109)
9 changes: 0 additions & 9 deletions ...nalyzers/Core/Microsoft.CodeQuality.Analyzers/MicrosoftCodeQualityAnalyzersResources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1095,15 +1095,6 @@
<data name="MarkMembersAsStaticMessage" xml:space="preserve">
<value>Member '{0}' does not access instance data and can be marked as static</value>
</data>
<data name="ReviewVisibleEventHandlersTitle" xml:space="preserve">
<value>Review visible event handlers</value>
</data>
<data name="ReviewVisibleEventHandlersDescription" xml:space="preserve">
<value>A public or protected event-handling method was detected. Event-handling methods should not be exposed unless absolutely necessary.</value>
</data>
<data name="ReviewVisibleEventHandlersMessageDefault" xml:space="preserve">
<value>Consider making '{0}' not externally visible</value>
</data>
<data name="SealMethodsThatSatisfyPrivateInterfacesTitle" xml:space="preserve">
<value>Seal methods that satisfy private interfaces</value>
</data>
Expand Down
29 changes: 0 additions & 29 deletions ...ore/Microsoft.CodeQuality.Analyzers/QualityGuidelines/ReviewVisibleEventHandlers.Fixer.cs
View file
Open in desktop

This file was deleted.

66 changes: 0 additions & 66 deletions ...zers/Core/Microsoft.CodeQuality.Analyzers/QualityGuidelines/ReviewVisibleEventHandlers.cs
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions ...rs/Core/Microsoft.CodeQuality.Analyzers/xlf/MicrosoftCodeQualityAnalyzersResources.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,21 +1877,6 @@
<target state="translated">Člen {0} nemá přístup k datům instance a je možné ho označit jako statický.</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersTitle">
<source>Review visible event handlers</source>
<target state="translated">Kontrola viditelných obslužných rutin událostí</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersDescription">
<source>A public or protected event-handling method was detected. Event-handling methods should not be exposed unless absolutely necessary.</source>
<target state="translated">Zjistila se veřejná nebo chráněná metoda zpracování událostí. Metody zpracování událostí by neměly být vystaveny, pokud to není nezbytně nutné.</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersMessageDefault">
<source>Consider making '{0}' not externally visible</source>
<target state="translated">Nastavte metodu {0} tak, aby nebyla externě viditelná.</target>
<note />
</trans-unit>
<trans-unit id="SealMethodsThatSatisfyPrivateInterfacesTitle">
<source>Seal methods that satisfy private interfaces</source>
<target state="translated">Zapečetění metod, které vyhovují privátním rozhraním</target>
Expand Down
15 changes: 0 additions & 15 deletions ...rs/Core/Microsoft.CodeQuality.Analyzers/xlf/MicrosoftCodeQualityAnalyzersResources.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,21 +1877,6 @@
<target state="translated">Der Member "{0}" greift nicht auf Instanzdaten zu und kann als "static" markiert werden.</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersTitle">
<source>Review visible event handlers</source>
<target state="translated">Sichtbare Ereignishandler überprüfen</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersDescription">
<source>A public or protected event-handling method was detected. Event-handling methods should not be exposed unless absolutely necessary.</source>
<target state="translated">Es wurde eine öffentliche oder geschützte Methode zum Ereignishandling ermittelt. Methoden zum Ereignishandling dürfen nur verfügbar gemacht werden, wenn es absolut erforderlich ist.</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersMessageDefault">
<source>Consider making '{0}' not externally visible</source>
<target state="translated">Ziehen Sie in Betracht, "{0}" nicht extern sichtbar zu machen.</target>
<note />
</trans-unit>
<trans-unit id="SealMethodsThatSatisfyPrivateInterfacesTitle">
<source>Seal methods that satisfy private interfaces</source>
<target state="translated">Methoden versiegeln, die die Bedingungen privater Schnittstellen erfüllen</target>
Expand Down
15 changes: 0 additions & 15 deletions ...rs/Core/Microsoft.CodeQuality.Analyzers/xlf/MicrosoftCodeQualityAnalyzersResources.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,21 +1877,6 @@
<target state="translated">El miembro "{0}" no tiene acceso a los datos de la instancia y se puede marcar como static.</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersTitle">
<source>Review visible event handlers</source>
<target state="translated">Revisar los controladores de eventos visibles</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersDescription">
<source>A public or protected event-handling method was detected. Event-handling methods should not be exposed unless absolutely necessary.</source>
<target state="translated">Se detectó un método de control de eventos público o protegido. No se deberían exponer los métodos de control de eventos a menos que sea absolutamente necesario.</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersMessageDefault">
<source>Consider making '{0}' not externally visible</source>
<target state="translated">Podría hacer que "{0}" no fuera externamente visible.</target>
<note />
</trans-unit>
<trans-unit id="SealMethodsThatSatisfyPrivateInterfacesTitle">
<source>Seal methods that satisfy private interfaces</source>
<target state="translated">Sellar los métodos que cumplan las interfaces privadas</target>
Expand Down
15 changes: 0 additions & 15 deletions ...rs/Core/Microsoft.CodeQuality.Analyzers/xlf/MicrosoftCodeQualityAnalyzersResources.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,21 +1877,6 @@
<target state="translated">Le membre '{0}' n'accède pas aux données d'instance et peut être marqué comme étant static</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersTitle">
<source>Review visible event handlers</source>
<target state="translated">Passer en revue les gestionnaires d'événements visibles</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersDescription">
<source>A public or protected event-handling method was detected. Event-handling methods should not be exposed unless absolutely necessary.</source>
<target state="translated">Une méthode publique ou protégée de gestion des événements a été détectée. Les méthodes de gestion des événements ne doivent pas être exposées sauf en cas d'absolue nécessité.</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersMessageDefault">
<source>Consider making '{0}' not externally visible</source>
<target state="translated">Rendre '{0}' non visible de manière externe</target>
<note />
</trans-unit>
<trans-unit id="SealMethodsThatSatisfyPrivateInterfacesTitle">
<source>Seal methods that satisfy private interfaces</source>
<target state="translated">Sceller les méthodes qui satisfont les interfaces privées</target>
Expand Down
15 changes: 0 additions & 15 deletions ...rs/Core/Microsoft.CodeQuality.Analyzers/xlf/MicrosoftCodeQualityAnalyzersResources.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,21 +1877,6 @@
<target state="translated">Il membro {0} non accede ai dati di istanza e può essere contrassegnato come static</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersTitle">
<source>Review visible event handlers</source>
<target state="translated">Esaminare i gestori eventi visibili</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersDescription">
<source>A public or protected event-handling method was detected. Event-handling methods should not be exposed unless absolutely necessary.</source>
<target state="translated">È stato rilevato un metodo di gestione eventi public o protected. I metodi di gestione eventi devono essere esposti solo se assolutamente necessario.</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersMessageDefault">
<source>Consider making '{0}' not externally visible</source>
<target state="translated">Provare a rendere '{0}' non visibile esternamente</target>
<note />
</trans-unit>
<trans-unit id="SealMethodsThatSatisfyPrivateInterfacesTitle">
<source>Seal methods that satisfy private interfaces</source>
<target state="translated">Impostare come sealed i metodi che soddisfano interfacce private</target>
Expand Down
15 changes: 0 additions & 15 deletions ...rs/Core/Microsoft.CodeQuality.Analyzers/xlf/MicrosoftCodeQualityAnalyzersResources.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,21 +1877,6 @@
<target state="translated">メンバー '{0}' はインスタンス データにアクセスしないため、static にマークできます</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersTitle">
<source>Review visible event handlers</source>
<target state="translated">表示するイベント ハンドラーを確認します</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersDescription">
<source>A public or protected event-handling method was detected. Event-handling methods should not be exposed unless absolutely necessary.</source>
<target state="translated">パブリックまたは保護されたイベント処理メソッドが検出されました。イベント処理メソッドは、どうしても必要な場合を除いて公開しないでください。</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersMessageDefault">
<source>Consider making '{0}' not externally visible</source>
<target state="translated">'{0}' の外部からの参照を不可能に設定することを検討してください</target>
<note />
</trans-unit>
<trans-unit id="SealMethodsThatSatisfyPrivateInterfacesTitle">
<source>Seal methods that satisfy private interfaces</source>
<target state="translated">プライベート インターフェイスを満たすメソッドをシールします</target>
Expand Down
15 changes: 0 additions & 15 deletions ...rs/Core/Microsoft.CodeQuality.Analyzers/xlf/MicrosoftCodeQualityAnalyzersResources.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,21 +1877,6 @@
<target state="translated">'{0}' 멤버는 인스턴스 데이터에 액세스하지 않으며 static으로 표시할 수 있습니다.</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersTitle">
<source>Review visible event handlers</source>
<target state="translated">표시되는 이벤트 처리기를 검토하세요.</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersDescription">
<source>A public or protected event-handling method was detected. Event-handling methods should not be exposed unless absolutely necessary.</source>
<target state="translated">public 또는 protected 이벤트 처리 메서드가 검색되었습니다. 이벤트 처리 메서드는 필요한 경우에만 표시해야 합니다.</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersMessageDefault">
<source>Consider making '{0}' not externally visible</source>
<target state="translated">'{0}'이(가) 외부에 표시되지 않도록 하세요.</target>
<note />
</trans-unit>
<trans-unit id="SealMethodsThatSatisfyPrivateInterfacesTitle">
<source>Seal methods that satisfy private interfaces</source>
<target state="translated">private 인터페이스를 만족하는 메서드를 봉인하세요.</target>
Expand Down
15 changes: 0 additions & 15 deletions ...rs/Core/Microsoft.CodeQuality.Analyzers/xlf/MicrosoftCodeQualityAnalyzersResources.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,21 +1877,6 @@
<target state="translated">Składowa „{0}” nie uzyskuje dostępu do danych wystąpienia i może zostać oznaczona jako statyczna</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersTitle">
<source>Review visible event handlers</source>
<target state="translated">Przejrzyj widoczne procedury obsługi zdarzeń</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersDescription">
<source>A public or protected event-handling method was detected. Event-handling methods should not be exposed unless absolutely necessary.</source>
<target state="translated">Wykryto publiczną lub chronioną metodą obsługi zdarzeń. Nie należy ujawniać metod obsługi zdarzeń, o ile nie jest to absolutnie konieczne.</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersMessageDefault">
<source>Consider making '{0}' not externally visible</source>
<target state="translated">Rozważ przekształcenie elementu „{0}” w zewnętrznie niewidoczny</target>
<note />
</trans-unit>
<trans-unit id="SealMethodsThatSatisfyPrivateInterfacesTitle">
<source>Seal methods that satisfy private interfaces</source>
<target state="translated">Pieczętuj metody, które spełniają wymagania interfejsów prywatnych</target>
Expand Down
15 changes: 0 additions & 15 deletions ...Core/Microsoft.CodeQuality.Analyzers/xlf/MicrosoftCodeQualityAnalyzersResources.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1877,21 +1877,6 @@
<target state="translated">O membro '{0}' não acessa os dados da instância e pode ser marcado como estático</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersTitle">
<source>Review visible event handlers</source>
<target state="translated">Examinar manipuladores de eventos visíveis</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersDescription">
<source>A public or protected event-handling method was detected. Event-handling methods should not be exposed unless absolutely necessary.</source>
<target state="translated">Foi detectado um método de manipulação de eventos público ou protegido. Os métodos de manipulação de eventos não devem ser expostos, a menos que absolutamente necessário.</target>
<note />
</trans-unit>
<trans-unit id="ReviewVisibleEventHandlersMessageDefault">
<source>Consider making '{0}' not externally visible</source>
<target state="translated">Considere tornar {0} não visível externamente</target>
<note />
</trans-unit>
<trans-unit id="SealMethodsThatSatisfyPrivateInterfacesTitle">
<source>Seal methods that satisfy private interfaces</source>
<target state="translated">Métodos de lacre que satisfazem interfaces privadas</target>
Expand Down
Loading