Remove rule CA2109 #6198
Remove rule CA2109 #6198
Conversation
|
@x789 Can you fix the build please? |
|
@Youssef1313 I will fix it during the next week... |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6198 +/- ##
==========================================
- Coverage 96.08% 96.07% -0.01%
==========================================
Files 1366 1363 -3
Lines 315512 315269 -243
Branches 10187 10184 -3
==========================================
- Hits 303145 302904 -241
- Misses 9934 9935 +1
+ Partials 2433 2430 -3 |
|
All but one check are green. Code compiles and tests run flawlessly on my machine. I cannot reproduce the failing check and I assume, that it simply took too long and was therefore cancelled. @Youssef1313 Maybe you can have a look at it? |
|
It seems there are conflicts and too many extra commits that shouldn't exist. Could you fix that @x789? |
|
@Youssef1313: You're right, the PR was a bit confusing. I started over and put all the changes into one commit. Now the changes should be more understandable. |
|
|
||
| internal static readonly DiagnosticDescriptor Rule = DiagnosticDescriptorHelper.Create( | ||
| RuleId, | ||
| CreateLocalizableResourceString(nameof(ReviewVisibleEventHandlersTitle)), |
There was a problem hiding this comment.
consider deleting the unused resources as well
|
@mavasani for review |
|
@mavasani Is this ready to merge? |
This PR removes analyzer rule CA2109 and closes #5974.