Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dogfood latest 7.0.0 analyzers #6339

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Dogfood latest 7.0.0 analyzers #6339

merged 1 commit into from
Dec 20, 2022

Conversation

Youssef1313
Copy link
Member

We were behind few versions

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #6339 (e3b0de5) into main (fde4933) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6339   +/-   ##
=======================================
  Coverage   96.08%   96.08%           
=======================================
  Files        1366     1366           
  Lines      315512   315512           
  Branches    10187    10187           
=======================================
+ Hits       303145   303150    +5     
+ Misses       9934     9933    -1     
+ Partials     2433     2429    -4     

@Youssef1313 Youssef1313 marked this pull request as ready for review December 13, 2022 11:40
@Youssef1313 Youssef1313 requested a review from a team as a code owner December 13, 2022 11:40
@@ -47,7 +47,7 @@
<MicrosoftCodeAnalysisForRoslynDiagnosticsAnalyzersVersion>3.7.0</MicrosoftCodeAnalysisForRoslynDiagnosticsAnalyzersVersion>
<MicrosoftCodeAnalysisVersionForTests>4.4.0-2.22416.9</MicrosoftCodeAnalysisVersionForTests>
<DogfoodAnalyzersVersion>3.3.4-beta1.22418.3</DogfoodAnalyzersVersion>
<DogfoodNetAnalyzersVersion>5.0.4-preview1.21126.5</DogfoodNetAnalyzersVersion>
<DogfoodNetAnalyzersVersion>7.0.0</DogfoodNetAnalyzersVersion>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this did not generate any new build warnings from CA diagnostics?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was quite surprising, but yeah no new warnings :)

@mavasani mavasani merged commit 2a50945 into dotnet:main Dec 20, 2022
@github-actions github-actions bot added this to the vNext milestone Dec 20, 2022
@Youssef1313 Youssef1313 deleted the patch-23 branch December 20, 2022 13:19
@mavasani mavasani mentioned this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants